Skip to content

Conversation

@sacr1ficez
Copy link
Contributor

Fixes #611

Copy link
Member

@Lpsd Lpsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this, and it does produce a warning about scripts already being included, due to using globstar. This isn't really an issue, but it it's annoying.

Unfortunately I don't think this can be resolved with our current folder structure. Can you move all folders except config under a new folder called logic? So the structure would be:

meta.xml
config/
    SRadioConfig.lua
    CRadioConfig.lua
    ShRadioConfig.lua
logic/
    gui/
        CRadioGUI.lua
    settings/
        CRadioSettings.lua
... etc

Then we can update the logic script includes, for example:

<script src="logic/**/Sh*.lua" type="shared" cache="false"/>
<script src="logic/**/C*.lua" type="client" cache="false"/>
<script src="logic/**/S[!h]*.lua" type="server"/>

This will avoid the duplicate script warning.

Copy link
Member

@Lpsd Lpsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lpsd Lpsd merged commit effd3bb into multitheftauto:master Mar 18, 2025
1 check passed
@sacr1ficez sacr1ficez deleted the ir-fix branch March 18, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

internetradio: Warning due to script load order

2 participants