-
Notifications
You must be signed in to change notification settings - Fork 221
Fix boostrap from network #7564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sstanculeanu
merged 35 commits into
feat/supernova-async-exec
from
fix-meta-bootstrap-sync
Dec 29, 2025
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
51b3451
save intermediate header to storage on bootstrap
ssd04 c61e939
Merge branch 'feat/supernova-async-exec' into fix-meta-bootstrap-sync
ssd04 187313c
handle last included meta headers
ssd04 b39f967
Merge branch 'feat/supernova-async-exec' into fix-meta-bootstrap-sync
sstanculeanu dcfc4ab
fallback to search in storage
ssd04 880872e
Merge branch 'feat/supernova-async-exec' into fix-meta-bootstrap-sync
ssd04 5011943
request missing meta headers at bootstrap
ssd04 3a37ddb
remove unneded log
ssd04 bd53570
set last self notarized meta in tracker based on shard header
ssd04 7b59f02
Merge branch 'feat/supernova-async-exec' into fix-meta-bootstrap-sync
ssd04 1efc550
Merge branch 'feat/supernova-async-exec' into fix-meta-bootstrap-sync
ssd04 f7a164b
remove debug logs
ssd04 d197d3e
refactor getting from storage with nonce
ssd04 54b0c24
refactor epoch start last self notarized headers
ssd04 cfcbb2d
fix saving shard headers to storage
ssd04 00da184
fixes + unit tests
ssd04 ff4caa7
fix process tests
ssd04 6a43815
remove debug log
ssd04 ff89aab
Merge branch 'feat/supernova-async-exec' into fix-meta-bootstrap-sync
ssd04 8206f45
remove commented code
ssd04 e36c8ee
remove debug log
ssd04 dc6692d
Merge branch 'feat/supernova-async-exec' into fix-meta-bootstrap-sync
ssd04 0009304
add nonce check
ssd04 54fc584
refactor to not sync last executed header for last finished ref meta
ssd04 f58157e
fixes after review - typos
ssd04 df9793f
fixes after review - typos
ssd04 0d50c03
Merge branch 'feat/supernova-async-exec' into fix-meta-bootstrap-sync
ssd04 761ac1c
fix conflicts after merge
ssd04 8abf8f7
fix linter issue
ssd04 61401da
get ref meta header for last self notarized headers
ssd04 73b2142
fixes after review
ssd04 8661f6c
remove unused code
ssd04 dc91177
Merge branch 'feat/supernova-async-exec' into fix-meta-bootstrap-sync
sstanculeanu 6785359
fix request shard id
ssd04 4f5f4ee
fixes after review
ssd04 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated function: The fetchPrevHeader function in metaStorageHandler.go (lines 235-251) is identical to the syncPrevShardHeaderHandler method in process.go (lines 854-871), except the latter also stores the header in syncedHeaders. Consider extracting this into a shared utility function to avoid code duplication and potential maintenance issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainly the similar part is the type assertion, otherwise they are quite different since the other one uses
syncOneHeaderwhich needs other things like request, data pool, we can have a function pointer for this call, but it would be very similar with what we already have now