Skip to content

Conversation

@AdoAdoAdo
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@AdoAdoAdo AdoAdoAdo requested a review from Copilot December 30, 2025 11:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical issue where deferred revert operations for the current block would fail in headerV3 processing. The fix ensures that execution results are collected and stored in the header before committing state, allowing the deferred RevertCurrentBlock mechanism to properly access execution results when errors occur.

Key Changes

  • Reordered operations to call collectExecutionResults before commitState in meta block proposal processing
  • Fixed error variable handling to ensure the deferred revert function can properly detect errors
  • Added ClearFields() call for transaction syncer to match the pattern used for miniblock syncer

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
process/sync/baseSync.go Added ClearFields() call before syncing transactions, ensuring state is cleared consistently with miniblock syncing
process/block/shardblockProposal.go Changed error variable from errCutoff to err to enable deferred revert detection, and refactored variable declarations to explicitly avoid shadowing
process/block/metablockProposal.go Moved commitState after collectExecutionResults in both regular and epoch start proposal processing, ensuring execution results are available for deferred revert; refactored variable declarations for consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sstanculeanu
sstanculeanu previously approved these changes Dec 30, 2025
ssd04
ssd04 previously approved these changes Dec 30, 2025
@ssd04 ssd04 dismissed stale reviews from sstanculeanu and themself via 15f64b3 December 30, 2025 11:23
ssd04
ssd04 previously approved these changes Dec 30, 2025
sstanculeanu
sstanculeanu previously approved these changes Dec 30, 2025
@AdoAdoAdo AdoAdoAdo dismissed stale reviews from sstanculeanu and ssd04 via 5f7b61d December 30, 2025 12:00
sstanculeanu
sstanculeanu previously approved these changes Dec 30, 2025
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.69%. Comparing base (45236d8) to head (592af51).
⚠️ Report is 11 commits behind head on feat/supernova-async-exec.

Files with missing lines Patch % Lines
process/sync/baseSync.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           feat/supernova-async-exec    #7585      +/-   ##
=============================================================
- Coverage                      77.70%   77.69%   -0.01%     
=============================================================
  Files                            875      875              
  Lines                         120927   120898      -29     
=============================================================
- Hits                           93963    93931      -32     
- Misses                         20763    20774      +11     
+ Partials                        6201     6193       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdoAdoAdo AdoAdoAdo merged commit 1acfb3f into feat/supernova-async-exec Dec 30, 2025
10 of 11 checks passed
@AdoAdoAdo AdoAdoAdo deleted the fix-restore-after-process-fail branch December 30, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants