Skip to content

Bypass blocks signature #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axenteoctavian merged 10 commits into from
Dec 17, 2025
Merged

Bypass blocks signature #183

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b5b9d4d
Bypass blocks signature
axenteoctavian Dec 2, 2025
048498d
fix go.mod
axenteoctavian Dec 2, 2025
71da764
Merge branch 'rc/supernova' into bypass-blocks-signature
axenteoctavian Dec 3, 2025
52726eb
Update go.mod
axenteoctavian Dec 8, 2025
71e8fa6
Merge branch 'rc/supernova' into bypass-blocks-signature
axenteoctavian Dec 12, 2025
8c773ac
Update go.mod
axenteoctavian Dec 12, 2025
205b7bc
Merge branch 'refs/heads/rc/supernova' into bypass-blocks-signature
axenteoctavian Dec 16, 2025
5030edd
Update go.mod
axenteoctavian Dec 16, 2025
3a46bd4
fixes after review
axenteoctavian Dec 16, 2025
afdf5d0
Merge branch 'rc/supernova' into bypass-blocks-signature
axenteoctavian Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/chainsimulator/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ import (
"time"

logger "github.com/multiversx/mx-chain-logger-go"
"github.com/multiversx/mx-chain-simulator-go/config"
"github.com/urfave/cli"

"github.com/multiversx/mx-chain-simulator-go/config"
)

const nodeOverrideDefaultFilename = "nodeOverrideDefault.toml"
Expand Down Expand Up @@ -95,6 +96,10 @@ var (
Name: "bypass-txs-signature",
Usage: "This flag is used to bypass the transactions signature verification (by default true)",
}
bypassBlocksSignature = cli.BoolTFlag{
Name: "bypass-blocks-signature",
Usage: "This flag is used to bypass the blocks signature verification (by default true)",
}
numValidatorsPerShard = cli.IntFlag{
Name: "num-validators-per-shard",
Usage: "This flag is used to specify the number of validators per shard",
Expand Down
7 changes: 6 additions & 1 deletion cmd/chainsimulator/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,15 @@ import (
"github.com/multiversx/mx-chain-go/node/chainSimulator/components/api"
logger "github.com/multiversx/mx-chain-logger-go"
"github.com/multiversx/mx-chain-logger-go/file"
"github.com/urfave/cli"

"github.com/multiversx/mx-chain-simulator-go/config"
"github.com/multiversx/mx-chain-simulator-go/pkg/facade"
"github.com/multiversx/mx-chain-simulator-go/pkg/factory"
endpoints "github.com/multiversx/mx-chain-simulator-go/pkg/proxy/api"
"github.com/multiversx/mx-chain-simulator-go/pkg/proxy/configs"
"github.com/multiversx/mx-chain-simulator-go/pkg/proxy/configs/git"
"github.com/multiversx/mx-chain-simulator-go/pkg/proxy/creator"
"github.com/urfave/cli"
)

const timeToAllowProxyToStart = time.Millisecond * 10
Expand Down Expand Up @@ -74,6 +75,7 @@ func main() {
roundDurationInMs,
supernovaRoundDurationInMs,
bypassTransactionsSignature,
bypassBlocksSignature,
numValidatorsPerShard,
numWaitingValidatorsPerShard,
numValidatorsMeta,
Expand Down Expand Up @@ -139,6 +141,8 @@ func startChainSimulator(ctx *cli.Context) error {

bypassTxsSignature := ctx.GlobalBool(bypassTransactionsSignature.Name)
log.Warn("signature", "bypass", bypassTxsSignature)
bypassBlocksSignature := ctx.GlobalBool(bypassBlocksSignature.Name)
log.Warn("blocks", "bypass", bypassBlocksSignature)
Copy link

@mariusmihaic mariusmihaic Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why warn?
I understand the above signature bypass log is set to Warn, but why?

Copy link
Author

@axenteoctavian axenteoctavian Dec 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know but I changed it to DEBUG

roundDurationInMillis := uint64(cfg.Config.Simulator.RoundDurationInMs)
supernovaRoundDurationInMillis := uint64(cfg.Config.Simulator.SupernovaRoundDurationInMs)
rounds := core.OptionalUint64{
Expand Down Expand Up @@ -180,6 +184,7 @@ func startChainSimulator(ctx *cli.Context) error {
var alterConfigsError error
argsChainSimulator := chainSimulator.ArgsChainSimulator{
BypassTxSignatureCheck: bypassTxsSignature,
BypassBlockSignatureCheck: bypassBlocksSignature,
TempDir: tempDir,
PathToInitialConfig: nodeConfigs,
NumOfShards: uint32(cfg.Config.Simulator.NumOfShards),
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require (
github.com/btcsuite/websocket v0.0.0-20150119174127-31079b680792
github.com/gin-gonic/gin v1.10.0
github.com/multiversx/mx-chain-core-go v1.4.2-0.20251022090220-a99e14e45706
github.com/multiversx/mx-chain-go v1.11.2-0.20251215095623-aaca4d73f477
github.com/multiversx/mx-chain-go v1.11.2-0.20251216071517-7cafe0a2a8bf
github.com/multiversx/mx-chain-logger-go v1.1.0
github.com/multiversx/mx-chain-proxy-go v1.3.1
github.com/pelletier/go-toml v1.9.3
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,8 @@ github.com/multiversx/mx-chain-crypto-go v1.3.0 h1:0eK2bkDOMi8VbSPrB1/vGJSYT81IB
github.com/multiversx/mx-chain-crypto-go v1.3.0/go.mod h1:nPIkxxzyTP8IquWKds+22Q2OJ9W7LtusC7cAosz7ojM=
github.com/multiversx/mx-chain-es-indexer-go v1.9.3-0.20251021150757-bd6aa66a0a90 h1:Hf6AqpCSHccBo5ZV5Bfaxz3UdPYhtYCynU+3CF4jAa8=
github.com/multiversx/mx-chain-es-indexer-go v1.9.3-0.20251021150757-bd6aa66a0a90/go.mod h1:t1rkD2vHXSI4EClig0h7+kRCSUCRrMF+emr4DHxFtfA=
github.com/multiversx/mx-chain-go v1.11.2-0.20251215095623-aaca4d73f477 h1:0q0KCLjYrG4AXKcNIBQnyMrqBcMbx1xRDG4bgcyVLqc=
github.com/multiversx/mx-chain-go v1.11.2-0.20251215095623-aaca4d73f477/go.mod h1:G2LX81y+A75W5EqJod9p4fRAdnp22vpQrB+374pAveQ=
github.com/multiversx/mx-chain-go v1.11.2-0.20251216071517-7cafe0a2a8bf h1:5M6K4UOEy8exs4plUhxfQOa2SVtTD5IU/1D9zWWwSBY=
github.com/multiversx/mx-chain-go v1.11.2-0.20251216071517-7cafe0a2a8bf/go.mod h1:G2LX81y+A75W5EqJod9p4fRAdnp22vpQrB+374pAveQ=
github.com/multiversx/mx-chain-logger-go v1.1.0 h1:97x84A6L4RfCa6YOx1HpAFxZp1cf/WI0Qh112whgZNM=
github.com/multiversx/mx-chain-logger-go v1.1.0/go.mod h1:K9XgiohLwOsNACETMNL0LItJMREuEvTH6NsoXWXWg7g=
github.com/multiversx/mx-chain-proxy-go v1.3.1 h1:tjbTm3FpR0bjDvWAMK0zwRxRbbjGszSWltng7jv6CIg=
Expand Down
Loading