Merged
Conversation
…n-vm-go into update_go_1.22 # Conflicts: # go.mod # go.sum
# Conflicts: # .github/workflows/build-test.yml # go.mod # go.sum # vmhost/flags.go # vmhost/hostCore/host.go # vmhost/vmhooks/manBufOps.go # vmhost/vmhooks/vmHooksImpl.go
sasurobert
reviewed
Feb 17, 2025
| executorFactory: nil, | ||
| enableEpochsHandler: &worldmock.EnableEpochsHandlerStub{ | ||
| IsFlagEnabledCalled: func(flag core.EnableEpochFlag) bool { | ||
| return flag != vmhost.ValidationOnGobDecodeFlag // relevant for big float tests. TODO: remove this when completely migrate to go1.22 |
Contributor
There was a problem hiding this comment.
this is not good. Shouldn't be default for all the tests. So will rewrite it tomorrow this part.
sasurobert
previously approved these changes
Feb 18, 2025
andrei-marinica
previously approved these changes
Feb 18, 2025
sstanculeanu
dismissed stale reviews from andrei-marinica and sasurobert
via
240f5e8
…m-go into update_go_1.22 # Conflicts: # go.mod # go.sum
sasurobert
approved these changes
Feb 20, 2025
andrei-marinica
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.