Harden VM against invalid inputs and add security checks #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces several security enhancements to the VM host to make it more robust against potentially malicious smart contract code. The following changes were made: - In `vmhooks/bigIntOps.go`, changed silent failures for out-of-range argument indexes to explicit execution failures. - In `vmhooks/manBufOps.go`, changed silent failures for out-of-bounds slice operations to explicit execution failures. - In `vmhooks/manBufOps.go`, added a `recover` block to `MBufferToBigFloat` to prevent panics in `GobDecode` from crashing the VM. - In `contexts/managedType.go`, improved the bounds checking in `GetSlice` to be safer against integer overflows. - In `hostCore/execution.go`, removed a redundant `defer` block to improve code clarity. - Updated several test scenarios to reflect the new, stricter error handling.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #948 +/- ##
=======================================
Coverage 36.22% 36.22%
=======================================
Files 87 87
Lines 20589 20600 +11
=======================================
+ Hits 7459 7463 +4
- Misses 12463 12467 +4
- Partials 667 670 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR hardens the VM against invalid inputs by replacing silent failures with explicit execution failures and adding security checks to prevent crashes from malicious smart contract code.
- Converts silent failures to explicit execution failures in
bigIntOps.goandmanBufOps.gofor out-of-range operations - Adds panic recovery to
MBufferToBigFloatto prevent VM crashes from malformed data - Improves bounds checking logic in
managedType.goto prevent integer overflow vulnerabilities
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vmhost/vmhooks/manBufOps.go | Converts silent bounds failures to explicit execution failures and adds panic recovery for GobDecode |
| vmhost/vmhooks/bigIntOps.go | Converts silent argument index failures to explicit execution failures |
| vmhost/contexts/managedType.go | Improves bounds checking to prevent integer overflow vulnerabilities |
| vmhost/hostCore/execution.go | Removes redundant defer block for code clarity |
| Multiple test files | Updates test expectations to reflect new error handling behavior |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
added to a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces several security enhancements to the VM host to make it more robust against potentially malicious smart contract code.
The following changes were made:
vmhooks/bigIntOps.go, changed silent failures for out-of-range argument indexes to explicit execution failures.vmhooks/manBufOps.go, changed silent failures for out-of-bounds slice operations to explicit execution failures.vmhooks/manBufOps.go, added arecoverblock toMBufferToBigFloatto prevent panics inGobDecodefrom crashing the VM.contexts/managedType.go, improved the bounds checking inGetSliceto be safer against integer overflows.hostCore/execution.go, removed a redundantdeferblock to improve code clarity.