Add unit tests for vmhost #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurci
previously approved these changes
Aug 6, 2025
…it, without fixing.
…it, without fixing.
…it, without fixing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rc/after-supernova #957 +/- ##
======================================================
+ Coverage 36.23% 41.19% +4.95%
======================================================
Files 87 87
Lines 20589 20587 -2
======================================================
+ Hits 7460 8480 +1020
+ Misses 12462 11210 -1252
- Partials 667 897 +230 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
laurci
approved these changes
Aug 11, 2025
andrei-marinica
approved these changes
Aug 12, 2025
| ) | ||
|
|
||
| func TestAddAsyncArgumentsToOutputTransfers(t *testing.T) { | ||
| t.Parallel() |
Contributor
There was a problem hiding this comment.
Does it help for these tests to run in parallel? It looks like they are only testing object construction.
Contributor
Author
There was a problem hiding this comment.
always help. it is faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.