initial implementation of unSafe mode #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## rc/after-supernova #962 +/- ##
======================================================
- Coverage 41.31% 40.95% -0.37%
======================================================
Files 87 88 +1
Lines 20538 20710 +172
======================================================
- Hits 8486 8481 -5
- Misses 11152 11322 +170
- Partials 900 907 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # vmhost/errors.go # vmhost/flags.go # vmhost/hostCore/host.go # vmhost/vmhooks/bigIntOps.go # vmhost/vmhooks/manBufOps.go
sasurobert
changed the base branch from
rc/after-supernova
to
start-resolving-todos
# Conflicts: # mock/mockery/RuntimeContext.go
laurci
previously approved these changes
Aug 12, 2025
sasurobert
changed the base branch from
start-resolving-todos
to
rc/after-supernova
# Conflicts: # vmhost/vmhooks/baseOps.go
laurci
previously approved these changes
Aug 20, 2025
laurci
previously approved these changes
Aug 20, 2025
laurci
approved these changes
Aug 20, 2025
andrei-marinica
approved these changes
Aug 20, 2025
|
|
||
| func (context *VMHooksImpl) useGasForUnsafeActivation(traceString string) error { | ||
| metering := context.GetMeteringContext() | ||
| gasToUse := metering.GasSchedule().BaseOpsAPICost.Finish |
Contributor
There was a problem hiding this comment.
Should probably add a specific api cost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs: