Merged
Conversation
mgavrila
previously approved these changes
Jul 23, 2025
…hadow dom elements (#172) * Add getElementByDataTestIdDeep utility function for enhanced testing capabilities * Update CHANGELOG to reflect the addition of getElementByDataTestIdDeep utility function for tests * Refactor getElementByDataTestIdDeep to utilize walkShadowDom for improved shadow DOM traversal; add tests for walkShadowDom functionality * Refactor shadow DOM traversal tests by removing unnecessary comments and improving clarity; streamline walkShadowDom function for better readability * Refactor tests for getElementByDataTestIdDeep by removing redundant comments and enhancing code clarity; ensure consistent formatting in test cases. --------- Co-authored-by: Tudor Morar <tudor.morar@multiversx.com>
razvantomegea
previously approved these changes
Jul 23, 2025
razvantomegea
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue/Feature
Reproduce
Issue exists on version
1.of sdk-dapp-ui.Root cause
Fix
Additional changes
Contains breaking changes
[x] No
[] Yes
Updated CHANGELOG
[x] Yes
Testing
[x] User testing
[] Unit tests