Added custom notification support #21
Conversation
|
add CHANGELOG |
| styleUrl: 'custom-create-toast.css', | ||
| shadow: true, | ||
| }) | ||
| export class CustomToast { |
There was a problem hiding this comment.
rename file to custom-toast (match file name with component name)
| } | ||
|
|
||
| private initializeToast(container: HTMLElement) { | ||
| if (container && !container.hasChildNodes()) { |
| styleUrl: 'simple-toast.css', | ||
| shadow: true, | ||
| }) | ||
| export class TransactionToastContent { |
There was a problem hiding this comment.
either change file name or component name to match each other
| @Event() handleDeleteToast: EventEmitter<void>; | ||
|
|
||
| render() { | ||
| const { icon, iconClassName, title, message, subtitle: notificationStatus } = this.toast; |
There was a problem hiding this comment.
notificationStatus no need, keep using subtitle
|
|
||
| <button onClick={() => this.handleDeleteToast.emit()} type="button" class="icon-close" innerHTML={getIconHtmlFromIconDefinition(faTimes)}></button> | ||
|
|
||
| {notificationStatus && <div class="status-title">{notificationStatus}</div>} |
There was a problem hiding this comment.
class="status-title" --> class="subtitle"
| @Event() handleDeleteToast: EventEmitter<string>; | ||
|
|
||
| render() { | ||
| if (this.toast.instantiateToastElement) { |
There was a problem hiding this comment.
typeof this.toast.instantiateToastElement === function
There was a problem hiding this comment.
i change it to check for the element
| @Component({ | ||
| tag: 'custom-toast', | ||
| }) | ||
| export class CustomToast { |
There was a problem hiding this comment.
maybe rename this to GenericToast
|
|
||
| render() { | ||
| if (this.toast.instantiateToastElement) { | ||
| return <custom-create-toast toast={this.toast as IComponentToastType} onHandleDeleteToast={() => this.handleDeleteToast.emit(this.toast.toastId)} />; |
There was a problem hiding this comment.
and rename this to CustomToast
| @@ -0,0 +1,66 @@ | |||
| import { IconName } from '@fortawesome/free-solid-svg-icons'; | |||
There was a problem hiding this comment.
Add comment on top of file
// match these interfaces with src/path-to-file.type.ts from sdk-dapp
| export class ToastList { | ||
| private eventBus: IEventBus = new EventBus(); | ||
| @Prop() transactionToasts: ITransactionToast[]; | ||
| @Prop() customToasts: ICustomToastType[]; |
Issue/Feature
Added custom notification support
[] Yes
Updated CHANGELOG
[x] Yes
Testing
[x] User testing
[] Unit tests