Skip to content

Conversation

@iuliacimpeanu
Copy link
Collaborator

Issue/Feature

Build failed because of stencil/core newer version.

Contains breaking changes

[x] No

[] Yes

Updated CHANGELOG

[x] Yes

Testing

[x] User testing
[] Unit tests

@gemini-code-assist
Copy link

Summary of Changes

Hello @iuliacimpeanu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a build failure that was occurring due to compatibility issues with a newer version of stencil/core. By pinning the @stencil/core dependency to a specific version, the change ensures consistent and stable build behavior, mitigating unexpected problems from future dependency updates.

Highlights

  • Dependency Pinning: The @stencil/core dependency in package.json has been updated from ^4.36.2 to 4.36.2. This change pins the dependency to an exact version, preventing automatic updates to newer minor or patch versions that could introduce compatibility issues.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a build failure by pinning the @stencil/core dependency to a specific version. This is a valid strategy to resolve the immediate issue. My review includes one comment regarding the long-term maintainability and security implications of pinning this dependency, suggesting a follow-up action. The change itself is correct for its intended purpose.

@iuliacimpeanu iuliacimpeanu marked this pull request as ready for review December 11, 2025 13:48
@iuliacimpeanu iuliacimpeanu merged commit ce67d4b into development Dec 11, 2025
2 checks passed
@iuliacimpeanu iuliacimpeanu deleted the ic-fix-compatibility branch December 11, 2025 14:02
iuliacimpeanu added a commit that referenced this pull request Dec 11, 2025
* Refactored sign transactions panel internal components (#267)

* Update styles

* Refactored sign transactions footer

* Refactored copy button

* Refactored button component

* Refactored tooltip component

* Refactored spinner icon component

* Refactored arrow right component

* Updated copy button

* Updated styles

* Refactored sign transactions overview

* Refactored sign-transactions-advanced and sign-transactions-header

* Updated styles

* Fixed test

* Updated changelog

* Updated files

* Fixes after review

* Eslint and prettierrc fixes (#270)

* Eslint fixes

* Prettierrc fixes

* Updated changelog

* Added minimize/maximize toasts (#272)

* Added min/max toasts

* Update changelog

* Replace icon

* Fixed trimmed address not showing in address-table (#273)

* Fixed addresses not showing

* Fix issue with trimWrapperVisible

* Fixed unlockPanelFooter styles

* Updated Trim

* Updated Trim

* Updated changelog

---------

Co-authored-by: Gavrila Andrei <[email protected]>

* Refactored side panel components (#271)

* Update styles

* Refactored sign transactions footer

* Refactored copy button

* Refactored button component

* Refactored tooltip component

* Refactored spinner icon component

* Refactored arrow right component

* Updated copy button

* Updated styles

* Refactored sign transactions overview

* Refactored sign-transactions-advanced and sign-transactions-header

* Updated styles

* Updated styles

* Fixed test

* Updated changelog

* Updated changelog

* Updated files

* Fixes after review

* Fixes after review

* Updates files location

* Refactored side-panel-header comp

* Refactored side-panel comp

* Refactored side-panel-swipper styles

* Refactored side panel swiper component.

* Updated components

* Updated styles

* Updated changelog

* Fixed test

* Fixes after review

* Refactored transaction list item (#274)

* Refactored styles

* Refactored transaction-list-item component

* Updated changelog

* Fixed tests

* Fixes after review

* Upgraded version

* Fixed copy button (#276)

* Fixed copy button

* Upgraded version

* Sync development with main (#278)

* 0.1.5 (#275)

* Refactored sign transactions panel internal components (#267)

* Update styles

* Refactored sign transactions footer

* Refactored copy button

* Refactored button component

* Refactored tooltip component

* Refactored spinner icon component

* Refactored arrow right component

* Updated copy button

* Updated styles

* Refactored sign transactions overview

* Refactored sign-transactions-advanced and sign-transactions-header

* Updated styles

* Fixed test

* Updated changelog

* Updated files

* Fixes after review

* Eslint and prettierrc fixes (#270)

* Eslint fixes

* Prettierrc fixes

* Updated changelog

* Added minimize/maximize toasts (#272)

* Added min/max toasts

* Update changelog

* Replace icon

* Fixed trimmed address not showing in address-table (#273)

* Fixed addresses not showing

* Fix issue with trimWrapperVisible

* Fixed unlockPanelFooter styles

* Updated Trim

* Updated Trim

* Updated changelog

---------

Co-authored-by: Gavrila Andrei <[email protected]>

* Refactored side panel components (#271)

* Update styles

* Refactored sign transactions footer

* Refactored copy button

* Refactored button component

* Refactored tooltip component

* Refactored spinner icon component

* Refactored arrow right component

* Updated copy button

* Updated styles

* Refactored sign transactions overview

* Refactored sign-transactions-advanced and sign-transactions-header

* Updated styles

* Updated styles

* Fixed test

* Updated changelog

* Updated changelog

* Updated files

* Fixes after review

* Fixes after review

* Updates files location

* Refactored side-panel-header comp

* Refactored side-panel comp

* Refactored side-panel-swipper styles

* Refactored side panel swiper component.

* Updated components

* Updated styles

* Updated changelog

* Fixed test

* Fixes after review

* Refactored transaction list item (#274)

* Refactored styles

* Refactored transaction-list-item component

* Updated changelog

* Fixed tests

* Fixes after review

* Upgraded version

---------

Co-authored-by: Gavrila Andrei <[email protected]>

* Updated changelog

---------

Co-authored-by: Gavrila Andrei <[email protected]>

* Fixed compatibility issue on stencil/core (#279)

* Updated package version

* Updated changelog

* Updated lockfile

---------

Co-authored-by: Gavrila Andrei <[email protected]>
Co-authored-by: Tudor Morar <[email protected]>
iuliacimpeanu added a commit that referenced this pull request Dec 11, 2025
* Refactored sign transactions panel internal components (#267)

* Update styles

* Refactored sign transactions footer

* Refactored copy button

* Refactored button component

* Refactored tooltip component

* Refactored spinner icon component

* Refactored arrow right component

* Updated copy button

* Updated styles

* Refactored sign transactions overview

* Refactored sign-transactions-advanced and sign-transactions-header

* Updated styles

* Fixed test

* Updated changelog

* Updated files

* Fixes after review

* Eslint and prettierrc fixes (#270)

* Eslint fixes

* Prettierrc fixes

* Updated changelog

* Added minimize/maximize toasts (#272)

* Added min/max toasts

* Update changelog

* Replace icon

* Fixed trimmed address not showing in address-table (#273)

* Fixed addresses not showing

* Fix issue with trimWrapperVisible

* Fixed unlockPanelFooter styles

* Updated Trim

* Updated Trim

* Updated changelog

---------

Co-authored-by: Gavrila Andrei <[email protected]>

* Refactored side panel components (#271)

* Update styles

* Refactored sign transactions footer

* Refactored copy button

* Refactored button component

* Refactored tooltip component

* Refactored spinner icon component

* Refactored arrow right component

* Updated copy button

* Updated styles

* Refactored sign transactions overview

* Refactored sign-transactions-advanced and sign-transactions-header

* Updated styles

* Updated styles

* Fixed test

* Updated changelog

* Updated changelog

* Updated files

* Fixes after review

* Fixes after review

* Updates files location

* Refactored side-panel-header comp

* Refactored side-panel comp

* Refactored side-panel-swipper styles

* Refactored side panel swiper component.

* Updated components

* Updated styles

* Updated changelog

* Fixed test

* Fixes after review

* Refactored transaction list item (#274)

* Refactored styles

* Refactored transaction-list-item component

* Updated changelog

* Fixed tests

* Fixes after review

* Upgraded version

* Fixed copy button (#276)

* Fixed copy button

* Upgraded version

* Sync development with main (#278)

* 0.1.5 (#275)

* Refactored sign transactions panel internal components (#267)

* Update styles

* Refactored sign transactions footer

* Refactored copy button

* Refactored button component

* Refactored tooltip component

* Refactored spinner icon component

* Refactored arrow right component

* Updated copy button

* Updated styles

* Refactored sign transactions overview

* Refactored sign-transactions-advanced and sign-transactions-header

* Updated styles

* Fixed test

* Updated changelog

* Updated files

* Fixes after review

* Eslint and prettierrc fixes (#270)

* Eslint fixes

* Prettierrc fixes

* Updated changelog

* Added minimize/maximize toasts (#272)

* Added min/max toasts

* Update changelog

* Replace icon

* Fixed trimmed address not showing in address-table (#273)

* Fixed addresses not showing

* Fix issue with trimWrapperVisible

* Fixed unlockPanelFooter styles

* Updated Trim

* Updated Trim

* Updated changelog

---------

Co-authored-by: Gavrila Andrei <[email protected]>

* Refactored side panel components (#271)

* Update styles

* Refactored sign transactions footer

* Refactored copy button

* Refactored button component

* Refactored tooltip component

* Refactored spinner icon component

* Refactored arrow right component

* Updated copy button

* Updated styles

* Refactored sign transactions overview

* Refactored sign-transactions-advanced and sign-transactions-header

* Updated styles

* Updated styles

* Fixed test

* Updated changelog

* Updated changelog

* Updated files

* Fixes after review

* Fixes after review

* Updates files location

* Refactored side-panel-header comp

* Refactored side-panel comp

* Refactored side-panel-swipper styles

* Refactored side panel swiper component.

* Updated components

* Updated styles

* Updated changelog

* Fixed test

* Fixes after review

* Refactored transaction list item (#274)

* Refactored styles

* Refactored transaction-list-item component

* Updated changelog

* Fixed tests

* Fixes after review

* Upgraded version

---------

Co-authored-by: Gavrila Andrei <[email protected]>

* Updated changelog

---------

Co-authored-by: Gavrila Andrei <[email protected]>

* Fixed compatibility issue on stencil/core (#279)

* Updated package version

* Updated changelog

* Updated lockfile

* Upgraded version

---------

Co-authored-by: Gavrila Andrei <[email protected]>
Co-authored-by: Tudor Morar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants