Skip to content

0.1.13#292

Merged
arhtudormorar merged 7 commits intomainfrom
development
Jan 20, 2026
Merged

0.1.13#292
arhtudormorar merged 7 commits intomainfrom
development

Conversation

@arhtudormorar
Copy link
Collaborator

Fixed Button data-testid attribute

@gemini-code-assist
Copy link

Summary of Changes

Hello @arhtudormorar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a minor but important correction to the Button component by renaming the dataTestId prop to 'data-testid'. This change ensures the attribute adheres to standard HTML naming conventions, which is crucial for consistent and reliable automated testing. The update is part of a new patch release, version 0.1.13, and is reflected in the project's changelog.

Highlights

  • Button Component Fix: The dataTestId prop in the Button component has been corrected to 'data-testid' to align with standard HTML attribute naming conventions, improving consistency and testability.
  • Version Update: The package version has been incremented from 0.1.12 to 0.1.13 to reflect this patch release.
  • Changelog Entry: The CHANGELOG.md file has been updated to include the 0.1.13 release, detailing the fix for the Button component's data-testid attribute.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix the data-testid attribute on the Button component and bumps the package version. While the version bump and changelog update are fine, the changes to the Button component in src/common/Button/Button.tsx unfortunately introduce a critical syntax error and a logical flaw that would break the data-testid functionality. I've provided comments with suggestions to fix these issues. The main problem is changing the prop name from dataTestId to 'data-testid', which doesn't match what the calling component provides.

radumojic
radumojic previously approved these changes Jan 20, 2026
mgavrila
mgavrila previously approved these changes Jan 20, 2026
* Refactor data-testid attributes across components

Updated all instances of 'dataTestId' to 'data-testid' in various components and their respective TypeScript definitions to ensure consistency and adherence to naming conventions. This change affects components such as ExplorerLink, FormatAmount, Trim, and others, enhancing the overall code quality and maintainability.

* Update CHANGELOG

* Tests passing

* Update classes

* Fix build
@arhtudormorar arhtudormorar dismissed stale reviews from mgavrila and radumojic via bb174a3 January 20, 2026 11:40
@arhtudormorar arhtudormorar merged commit f1524c9 into main Jan 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants