Merged
Conversation
Updated all instances of 'dataTestId' to 'data-testid' in various components and their respective TypeScript definitions to ensure consistency and adherence to naming conventions. This change affects components such as ExplorerLink, FormatAmount, Trim, and others, enhancing the overall code quality and maintainability.
radumojic
approved these changes
Jan 20, 2026
mgavrila
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
Normalize
data-testidusage across UI componentsSummary
This PR standardizes how test IDs are defined and propagated so that:
data-testid={...}.dataTestId?: stringprop mapped to thedata-testidattribute.'data-testid'in their props and internally alias todataTestId.Key Changes
Common TSX components
Button,FormatAmount,ValidFormatAmount,InvalidFormatAmount,Trim,ExplorerLink,UnlockButton:'data-testid'?: string.{'data-testid': dataTestId}.data-testid={dataTestId}on DOM elements.Stencil class components
mvx-button,mvx-trim,mvx-explorer-link,mvx-format-amount,mvx-data-with-explorer-link,TransactionAccount,TransactionAccountName,TransactionShards, etc.:@Prop({ attribute: 'data-testid' }) dataTestId?: stringwhere a test id is part of the public API.data-testid={this.dataTestId}(or equivalent).UnlockProviderButton,TransactionValue,TransactionHash,TransactionsTable, etc.) now passdata-testidinstead ofdataTestIdto underlying components.Stories & tests
argTypesupdated to use'data-testid'where the prop is configurable (e.g. Trim, DataWithExplorerLink).data-testid="...".data-with-explorer-link.spec.ts,transaction-account.spec.tsx,transaction-account-name.spec.tsx,transaction-shards.spec.tsxupdated to:data-testidattributes in HTML/JSX.[data-testid="..."].component.dataTestIdwhen needed.Rationale
dataTestIdanddata-testid.data-testid).dataTestIdproperty) while ensuring the HTML attribute is alwaysdata-testid.Testing
Build
pnpm run buildTests
pnpm testDataWithExplorerLinkTransactionAccountTransactionAccountNameTransactionShardsdata-testidbehavior. (In sandboxed CI-like environments,EPERMonnode_modulescan still cause infrastructure-level failures unrelated to these changes.)