Skip to content

Emit page value#294

Closed
arhtudormorar wants to merge 5 commits intodevelopmentfrom
tm/fix/emit-page-value
Closed

Emit page value#294
arhtudormorar wants to merge 5 commits intodevelopmentfrom
tm/fix/emit-page-value

Conversation

@arhtudormorar
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @arhtudormorar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an enhancement to the AddressTable component by adding a pageValue state, which allows for better control and interaction with pagination input. It also expands the public API by exporting utility functions to check for the availability of browser extensions like MetaMask. Additionally, various development dependencies, particularly related to React type definitions, have been updated to ensure compatibility and leverage newer features.

Highlights

  • Version Update: The project version has been bumped to 0.1.14.
  • AddressTable Component Enhancement: The AddressTable component now includes a pageValue state to manage and emit the current page input value, enhancing pagination control.
  • New Exported Helpers: Two new helper functions, getIsExtensionAvailable and getIsMetaMaskAvailable, are now exported, making them accessible for broader use within the SDK.
  • Dependency Updates: Development dependencies @types/react and @types/react-dom have been added or updated, along with related pnpm-lock.yaml changes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully updates the project version, introduces new helper functions for detecting browser extensions, and refactors the AddressTable component to manage and emit a pageValue state for its pagination. The dependency lockfile has also been updated accordingly. Overall, the changes enhance functionality and maintainability.

## [[0.1.13](https://github.com/multiversx/mx-sdk-dapp-ui/pull/293)] - 2026-01-20
## [[0.1.14](https://github.com/multiversx/mx-sdk-dapp-ui/pull/294)] - 2026-01-23

- [Bump version to 0.1.14, added `pageValue` state to `AddressTable` component, exported getIsExtensionAvailable and getIsMetaMaskAvailable, added @types/react and @types/react-dom as devDependencies](https://github.com/multiversx/mx-sdk-dapp-ui/pull/293)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request link for version 0.1.14 points to pull/293, which is the PR for 0.1.13. This appears to be a copy-paste error. Please update it to pull/294 to correctly reflect the current PR.

Suggested change
- [Bump version to 0.1.14, added `pageValue` state to `AddressTable` component, exported getIsExtensionAvailable and getIsMetaMaskAvailable, added @types/react and @types/react-dom as devDependencies](https://github.com/multiversx/mx-sdk-dapp-ui/pull/293)
- [Bump version to 0.1.14, added `pageValue` state to `AddressTable` component, exported getIsExtensionAvailable and getIsMetaMaskAvailable, added @types/react and @types/react-dom as devDependencies](https://github.com/multiversx/mx-sdk-dapp-ui/pull/294)


## [[0.1.13](https://github.com/multiversx/mx-sdk-dapp-ui/pull/292)] - 2026-01-20

- [Fixed data-testid attributes](https://github.com/multiversx/mx-sdk-dapp-ui/pull/293)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request link for version 0.1.13 points to pull/293, but the version header indicates pull/292. Please correct this link to pull/292 for accuracy.

Suggested change
- [Fixed data-testid attributes](https://github.com/multiversx/mx-sdk-dapp-ui/pull/293)
- [Fixed data-testid attributes](https://github.com/multiversx/mx-sdk-dapp-ui/pull/292)

@arhtudormorar arhtudormorar deleted the tm/fix/emit-page-value branch January 26, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant