Conversation
|
Contract comparison - from 473a955 to 55ee5d2
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the crowdfunding contract to improve code organization and make it more suitable for tutorial purposes. The main changes involve reordering the init function parameters and adding additional validation.
- Reordered
initparameters to puttoken_identifierfirst, followed bytargetanddeadline - Reorganized validation logic in
initto validate token identifier before other parameters - Added
is_fungible()check in thefundfunction to prevent NFTs/SFTs from being accepted
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| contracts/examples/crowdfunding/src/crowdfunding.rs | Updated init parameter order, reordered validation logic, and added fungible token check in fund |
| contracts/examples/crowdfunding/src/crowdfunding_proxy.rs | Updated proxy init method to match new parameter order |
| contracts/examples/crowdfunding/tests/crowdfunding_esdt_blackbox_test.rs | Updated test to use new parameter order in init call |
| contracts/examples/crowdfunding/scenarios/crowdfunding-init.scen.json | Updated scenario file arguments to match new parameter order |
| contracts/examples/crowdfunding/scenarios/egld-crowdfunding-init.scen.json | Updated scenario file arguments to match new parameter order |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
36
to
44
| require!( | ||
| self.status() == Status::FundingPeriod, | ||
| "cannot fund after deadline" | ||
| payment.token_identifier == self.cf_token_id().get(), | ||
| "wrong token" | ||
| ); | ||
| require!(payment.is_fungible(), "only fungible tokens accepted"); | ||
| require!( | ||
| payment.token_identifier == self.cf_token_identifier().get(), | ||
| "wrong token" | ||
| self.status() == Status::FundingPeriod, | ||
| "cannot fund after deadline" | ||
| ); |
There was a problem hiding this comment.
The validation order is suboptimal. The self.status() check (line 42) calls get_current_time_millis() and get_current_funds(), which involve blockchain queries and storage reads. The payment.is_fungible() check (line 40) is a simple local check. Moving the fungibility check before the status check would avoid unnecessary expensive operations when the payment is not fungible (e.g., NFTs).
Contributor
Author
There was a problem hiding this comment.
It doesn't matter, failure consumes all the gas either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to make the code flow better and suit it better for the tutorial.