Merged
Conversation
|
Contract comparison - from 84ef63a to 8b6d1ca
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for computing the integer k-th root (“nth root”) for BigUint and ManagedDecimal, including scenario tests and a dedicated error message for the invalid k = 0 case.
Changes:
- Implement
BigUint::nth_root(k)using Newton iteration, plus a small refactor to reuse exponentiation logic viapow_assign. - Add
ManagedDecimal::nth_root(k)that preserves scale by pre-scaling raw units before rooting. - Add scenario tests for both
BigUint::nth_rootandManagedDecimal::nth_root, plus a new error message constant fork = 0.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| framework/base/src/types/managed/wrapped/num/big_uint.rs | Adds pow_assign, nth_root, and Clone::clone_from optimization. |
| framework/base/src/types/managed/wrapped/managed_decimal.rs | Adds ManagedDecimal::nth_root with scale-preserving pre-scaling. |
| framework/base/src/types/managed/basic/big_int.rs | Adds Clone::clone_from to support cheaper cloning patterns. |
| framework/base/src/err_msg.rs | Adds BIG_UINT_NTH_ROOT_ZERO error message used by nth_root(0). |
| framework/scenario/tests/big_uint_test.rs | Adds coverage for BigUint::nth_root and the k=0 panic case. |
| framework/scenario/tests/managed_decimal_test.rs | Adds coverage for ManagedDecimal::nth_root (including floor behavior) and the k=0 panic case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR adds support for computing the integer k-th root (“nth root”) for
BigUintandManagedDecimal, including scenario tests and a dedicated error message for the invalidk = 0case.Changes:
BigUint::nth_root(k)using Newton iteration, plus a small refactor to reuse exponentiation logic viapow_assign.ManagedDecimal::nth_root(k)that preserves scale by pre-scaling raw units before rooting.BigUint::nth_rootandManagedDecimal::nth_root, plus a new error message constant fork = 0.