-
Notifications
You must be signed in to change notification settings - Fork 5
Review dependencies in setup.cfg #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for this @imagejan! Cleaning the dependencies and making them more explicit is definitely needed here. I'll have a look at the CI errors, most likely towards end of the week. |
This commit tried to list all direct dependencies explicitly. The aicsimageio dependency moves to the test dependencies.
6e0c19f to
0499f10
Compare
|
Hi @m-albert, sorry, the previous commit had a typo in I was digging into it because I had issues installing |
|
Great, all tests still pass 🙂 @m-albert would you be willing to merge this and then cut and deploy a patch release? This would simplify installation on our end.. |
I changed the settings so that your PRs shouldn't need approval anymore.
Interesting. I agree that |
Nice!
Definitely! I'd only change one thing, namely to remove |
|
We have:
napari-stitcher/src/napari_stitcher/viewer_utils.py Lines 15 to 16 in 1c0f2dc
... so we indeed require |
Sorry I got confused, this is wrong! Merging and creating a patch release. |
|
Yes you are completely right, thanks for showing the occurrences. |
|
Thank you for the super fast response! 🚀 |
|
Release is out, thank you for contributing :) |
Actually I recently stumbled upon the same issue. FYI the |
This commit tries to list all direct dependencies explicitly.
This is what running
pixi x pipreqs .\srcproduces:The
multiview-stitcher[aicsimageio]dependency moves to the test dependencies, as it's only required to load test data.