Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ jobs:
run: pnpm test:coverage

- name: Upload coverage to Codecov
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 node24 breaking change warning

The v6.0.0 release notes explicitly warn: "This version introduces support for node24 which may cause breaking changes for systems that do not currently support node24." The action's runtime (as specified in codecov's own action.yml) will be node24, independent of the node-version: '20' set for the project under test.

On modern ubuntu-latest GitHub-hosted runners this is unlikely to be an issue, but it is worth verifying that your runner environment supports node24 before merging, especially if you use self-hosted runners at any point.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/ci.yml
Line: 51

Comment:
**node24 breaking change warning**

The v6.0.0 release notes explicitly warn: *"This version introduces support for node24 which may cause breaking changes for systems that do not currently support node24."* The action's runtime (as specified in codecov's own `action.yml`) will be `node24`, independent of the `node-version: '20'` set for the project under test.

On modern `ubuntu-latest` GitHub-hosted runners this is unlikely to be an issue, but it is worth verifying that your runner environment supports node24 before merging, especially if you use self-hosted runners at any point.

How can I resolve this? If you propose a fix, please make it concise.

with:
fail_ci_if_error: false
Loading