-
-
Notifications
You must be signed in to change notification settings - Fork 48
✨ QDMI authentication via FoMaC #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 65 commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
074c7ff
:sparkles: QDMI authentication via FoMaC
marcelwa f1d4360
:rotating_light: Fix `clang-tidy` warnings
marcelwa c184cc3
:rotating_light: Fix `clang-tidy` warnings
marcelwa 9d17fe3
:recycle: Don't re-expose session parameter enum
marcelwa 97a863c
:recycle: Rename `setSessionParameter` to `setParameter`
marcelwa 5705a51
:fire: Remove module-level convenience functions for parameter settin…
marcelwa b2f8833
:label: Propagate changes to `.pyi`
marcelwa 4369473
:recycle: Session authentication via constructor parameters
marcelwa 84e6f35
:recycle: Rename the `FoMaC` class to `Session`
marcelwa 6a4dc71
:recycle: Adjust Qiskit-QDMI Python interface to adhere to new API
marcelwa 8380a22
:rotating_light: Fix `clang-tidy` warnings
marcelwa 594b3b3
:white_check_mark: Add placeholder tests for authentication
marcelwa 578b5f2
:bug: Guard session allocation
marcelwa b6ffb8a
:recycle: Improve URL validation regex
marcelwa 1db21eb
:art: Address CodeRabbit's suggestions
marcelwa ed6d6b4
:memo: Update documentation to reflect code changes
marcelwa 321ee04
:sparkles: Expose session authentication to QDMIProvider initializati…
marcelwa 7f5cbe9
:bug: Fixed regex format
marcelwa 36aaeae
:white_check_mark: Add authentication FoMaC C++ tests
marcelwa b4f495c
:rotating_light: Remove unused header
marcelwa 25b13ab
:memo: Documentation on session authentication
marcelwa 4dae4f1
:memo: CHANGELOG
marcelwa 5655d59
:rotating_light: Fix `clang-tidy` warnings
marcelwa bed169b
:art: Light code cleanup
marcelwa 9b76cd3
Merge branch 'main' into qdmi-auth
marcelwa 3206c7d
:sparkles: Expose CUSTOM `QDMI_Program_Format` parameters
marcelwa 77ed885
:art: Cleanup Session constructor
marcelwa 5ffabe0
Merge branch 'main' into qdmi-auth
marcelwa fe6b067
:art: Cleanup Session constructor in bindings
marcelwa 8f1b299
:rotating_light: Fix `clang-tidy` warnings
marcelwa 7c8047a
:safety_vest: Ensure partially instantiated sessions get cleaned up p…
marcelwa 5680e80
:art: Implement CodeRabbit's suggestions
marcelwa 3d8d402
:recycle: Refactor URL validation to allow local URLs and IPs
marcelwa 9843d31
:art: Refactor QDMI Provider args to kwargs
marcelwa f95d547
:recycle: Expose `QDMI_DEVICE_SESSION_PARAMETER`s via the `Driver`
marcelwa b0fed9a
:rotating_light: Address `clang-tidy` warnings
marcelwa 69467b9
:recycle: Refactor `QDMI_Device_impl_d` and `Session` initialization …
marcelwa fbb7873
:white_check_mark: Stricter Session tests to properly test updated pa…
marcelwa 74cfd1d
:white_check_mark: Test `Driver::addDynamicDeviceLibrary`
marcelwa 7882499
:green_heart: Fix RTD build
marcelwa 106452c
:art: Prefer SPDLOG macros over function calls
marcelwa d0d132c
:sparkles: Expose device library loading to Python
marcelwa 2e10639
Merge branch 'main' into qdmi-auth
marcelwa f0b3a32
:art: Implement CodeRabbit's suggestions
marcelwa 3fb8b1c
:rotating_light: Fix `clang-tidy` warnings
marcelwa ffb8ea5
Merge branch 'main' into qdmi-auth
marcelwa 685c609
Merge branch 'main' into qdmi-auth
burgholzer 5cd5f00
🩹 ensure session stays alive in provider
burgholzer 0a4f68f
♻️ refactor provider initialization to use session kwargs
burgholzer 8e7938c
🎨 remove redundant inline
burgholzer 5ea53a6
✅♻️ refine smoke tests
burgholzer 7b6fb8f
🐛 Fix custom QDMI property and parameter handling in SC and NA devices
burgholzer f8e719c
🐛 Lock the right mutex in the DD QDMI device
burgholzer 6be3b68
🎨 remove redundant initialization
burgholzer 5b7bd74
♻️ Enable thread-safe reference counting for QDMI devices singletons
burgholzer f9f0b6b
♻️ Allow repeated loading of QDMI device library with potentially dif…
burgholzer 23b8846
🎨 slightly adjust session parameter setter
burgholzer 951035b
🎨 reduce redundancy via new macro
burgholzer 8e84370
♻️ slightly refactor reference counting
burgholzer d617428
🔥 remove openLibHandles
burgholzer d6a5467
✅ add one more test case
burgholzer e432e56
🚚 move `NA` QDMI device in its right place
burgholzer 2e20fab
🩹 fix include dir
burgholzer 80e88dc
📝 better singleton management docstrings
burgholzer 086f7b2
🩹 fix invalid argument check
burgholzer 0b74445
🚨 additional clang-tidy naming convention rule
burgholzer 6d3dc52
♻️ rework thread-safe singleton logic
burgholzer 7af7e00
Merge branch 'main' into qdmi-auth
burgholzer cb6f1c2
Revert "🚨 additional clang-tidy naming convention rule"
burgholzer 676a8a1
♻️ simplify handling of static deinitialization order fiasco
burgholzer 090ee48
🚨 clang-tidy
burgholzer 724d2b8
🚨 fix compiler and linter warnings
burgholzer a3023d5
✨ add common definitions and utilities for QDMI
burgholzer 59b6db4
:memo: Add missing PR reference
marcelwa 1a49aea
:green_heart: Fix Windows tests by using `EXPECT_STREQ` instead of `E…
marcelwa df67ab4
:recycle: Refactor URL validation regex to allow IPv4 and IPv6 addresses
marcelwa 2ea83b7
:pencil2: Fix typo
marcelwa 931e0e4
:memo: Add comments to highlight the subtle difference between `strnc…
marcelwa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.