Skip to content

🚸 Portability improvements for the QIR runner #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
burgholzer merged 3 commits into from
Dec 30, 2025
Merged

🚸 Portability improvements for the QIR runner #1410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24d0f15
🏁 also use `std::system` on Windows
burgholzer Dec 5, 2025
37be3e8
🔧 explicitly set linker language for QIR executables
burgholzer Dec 5, 2025
5a2dc41
🛠️ escape paths in `std::system` call to support spaces on all platforms
burgholzer Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions test/qir/runner/test_qir_runner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@
#include <gtest/gtest.h>
#include <sstream>

#ifdef _WIN32
#define SYSTEM _wsystem
#else
#define SYSTEM std::system
#endif

namespace qir {
class QIRRunnerTest : public testing::TestWithParam<std::filesystem::path> {};

Expand All @@ -37,8 +31,8 @@ INSTANTIATE_TEST_SUITE_P(
TEST_P(QIRRunnerTest, QIRFile) {
const auto& file = GetParam();
std::ostringstream command;
command << EXECUTABLE_PATH << " " << file;
const auto result = SYSTEM(command.str().c_str());
command << "\"" << EXECUTABLE_PATH << "\" \"" << file << "\"";
const auto result = std::system(command.str().c_str());
EXPECT_EQ(result, 0);
}
} // namespace qir
1 change: 1 addition & 0 deletions test/qir/runtime/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ macro(ADD_QIR_CIRCUIT target_name circuit_path)
COMMENT "Compiling ${circuit_path} to ${circuit_name}.o")
add_executable(${target_name} ${circuit_name}.o)
target_link_libraries(${target_name} PRIVATE MQT::CoreQIRRuntime)
set_target_properties(${target_name} PROPERTIES LINKER_LANGUAGE CXX)
endif()
endmacro()

Expand Down
Loading