Skip to content

🐛 Fix CtrlOp::getBodyUnitary() for operations with parameters #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taminob wants to merge 5 commits into
base: main
Choose a base branch
from
+15 −1
Open

🐛 Fix CtrlOp::getBodyUnitary() for operations with parameters #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aaa00a1
:bug: Fix qco::CtrlOp::getBodyUnitary() for ops with params
taminob Jan 15, 2026
175ad4d
:bug: Fix qc::CtrlOp::getBodyUnitary() for ops with params
taminob Jan 15, 2026
d8c6488
:white_check_mark: Add test case for qco::CtrlOp::getBodyUnitary()
taminob Jan 15, 2026
6d88bb6
:memo: Add PR to CHANGELOG
taminob Jan 15, 2026
5fae654
Revert ":bug: Fix qc(o)::CtrlOp::getBodyUnitary() for ops with params"
taminob Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ This project adheres to [Semantic Versioning], with the exception that minor rel

### Added

- ✨ Add initial infrastructure for new QC and QCO MLIR dialects ([#1264], [#1402], [#1428], [#1430], [#1436], [#1443], [#1446], [#1465]) ([**@burgholzer**], [**@denialhaag**], [**@taminob**], [**@DRovara**], [**@li-mingbao**])
- ✨ Add initial infrastructure for new QC and QCO MLIR dialects ([#1264], [#1402], [#1428], [#1430], [#1436], [#1443], [#1446], [#1464], [#1465]) ([**@burgholzer**], [**@denialhaag**], [**@taminob**], [**@DRovara**], [**@li-mingbao**])

### Changed

Expand Down Expand Up @@ -315,6 +315,7 @@ _📚 Refer to the [GitHub Release Notes](https://github.com/munich-quantum-tool
<!-- PR links -->

[#1465]: https://github.com/munich-quantum-toolkit/core/pull/1465
[#1464]: https://github.com/munich-quantum-toolkit/core/pull/1464
[#1458]: https://github.com/munich-quantum-toolkit/core/pull/1458
[#1453]: https://github.com/munich-quantum-toolkit/core/pull/1453
[#1447]: https://github.com/munich-quantum-toolkit/core/pull/1447
Expand Down
13 changes: 13 additions & 0 deletions mlir/unittests/Dialect/QCO/IR/Modifiers/test_qco_ctrl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,3 +221,16 @@ TEST_F(QCOCtrlOpTest, ParserErrors) {
.get(),
nullptr);
}

TEST_F(QCOCtrlOpTest, bodyUnitaryWithParameter) {
auto reg = builder.allocQubitRegister(2);
builder.crx(1.0, reg[0], reg[1]);
auto ctrlOp = cast<CtrlOp>(builder.getBlock()->getOperations().back());
module = builder.finalize();

auto bodyUnitary = ctrlOp.getBodyUnitary();
// Test if a valid unitary operation is returned
ASSERT_TRUE(bodyUnitary);
// Ensure it contains the correct operation type
EXPECT_EQ(bodyUnitary.getBaseSymbol(), "rx");
}
Loading