Skip to content

🚚 Move pipeline tests to Compiler directory#1471

Merged
burgholzer merged 1 commit intomainfrom
move-pipeline-tests
Jan 18, 2026
Merged

🚚 Move pipeline tests to Compiler directory#1471
burgholzer merged 1 commit intomainfrom
move-pipeline-tests

Conversation

@denialhaag
Copy link
Member

Description

This PR moves the pipeline tests to the Compiler directory to align with the structure of the other unit tests.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag requested a review from burgholzer January 18, 2026 22:27
@denialhaag denialhaag self-assigned this Jan 18, 2026
@denialhaag denialhaag added refactor Anything related to code refactoring MLIR Anything related to MLIR labels Jan 18, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated unit test directory structure configuration in the build system.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

A CMake build configuration change in the MLIR unit tests directory replaces the pipeline subdirectory inclusion with Compiler subdirectory inclusion, modifying which unit test targets are built.

Changes

Cohort / File(s) Summary
Build Configuration
mlir/unittests/CMakeLists.txt
Replaced add_subdirectory(pipeline) with add_subdirectory(Compiler) to change which subdirectory is built for unit tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop through the CMake so fine,
From pipeline paths to Compiler's line,
One simple swap, a build anew,
The rabbit's test suite shines through! 🐰

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly references moving pipeline tests to the Compiler directory, which aligns with the main change in the PR of replacing add_subdirectory(pipeline) with add_subdirectory(Compiler).
Description check ✅ Passed The PR description includes a summary of the change, explains the motivation for alignment with other unit tests, and provides completed checklist items appropriately marking non-applicable items as skipped.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@burgholzer burgholzer added this to the MLIR Support milestone Jan 18, 2026
@burgholzer burgholzer merged commit 1ad9bb4 into main Jan 18, 2026
34 checks passed
@burgholzer burgholzer deleted the move-pipeline-tests branch January 18, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MLIR Anything related to MLIR refactor Anything related to code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants