feat: Adding AGENTS.md repository instructions for AI tooling#1518
feat: Adding AGENTS.md repository instructions for AI tooling#1518CodeMaverick2 wants to merge 16 commits intomunich-quantum-toolkit:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new repository-level documentation file Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@AGENTS.md`:
- Around line 193-205: The fenced code block in AGENTS.md that lists the project
layout lacks a language tag; update the opening triple-backtick for that block
to include a language specifier like "text" (i.e., change the code fence before
the directory list to ```text) so the directory structure renders correctly;
locate the block containing the lines starting with "include/mqt-core/" and
"src/" and add the language specifier to the existing fenced code block.
|
Thanks for your interest in contributing to the project as part of unitaryDESIGN! Great to see. Would you mind commenting on the respective issue (#1459) to indicate that you are working on this issue? I'll try to get some first feedback to you over the course of the day. |
denialhaag
left a comment
There was a problem hiding this comment.
Hi, @CodeMaverick2! Thanks a lot for the proposal! 🙂
I have gone through everything now and left a few comments where I still see some room for improvement.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@AGENTS.md`:
- Around line 40-45: Add a short note near the C++ linting section and/or the
CMake options table explaining that BUILD_MQT_CORE_BINDINGS is OFF by default
and that clang-tidy will not analyze bindings unless the linter build sets
-DBUILD_MQT_CORE_BINDINGS=ON; reference the CMake option name
BUILD_MQT_CORE_BINDINGS and the C++ linting/clang-tidy step in the docs so
readers know to enable bindings for full coverage.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@AGENTS.md`:
- Around line 232-233: Replace the heading text "**MLIR caveats**" with "**MLIR
cautions**" in AGENTS.md so the phrasing reads "MLIR cautions: MLIR is disabled
automatically on macOS with GCC (ABI incompatibility) and with AppleClang < 17
(incomplete C++20 support)"; keep the rest of the sentence intact and do not
modify the adjacent note about stub files.
- Around line 220-223: Update the OS/compiler matrix in AGENTS.md to clearly
separate "Regular CI" (always run) from "Extensive CI (requires extensive-cpp-ci
label)"; state that Regular CI runs: Ubuntu (GCC only), macOS 15 only, Windows
2025 only, and does not run Clang/GCC cross-combinations, whereas Extensive CI
(triggered by the extensive-cpp-ci label) covers the full matrix: macOS 14–15,
Windows 2022–2025, and compilers GCC 14+, Clang 20+, MSVC and AppleClang 17+
(including mixed GCC/Clang combinations). Ensure the wording replaces the
current undifferentiated list so contributors know which platforms/compilers are
always tested vs. label-gated.
denialhaag
left a comment
There was a problem hiding this comment.
Thanks a lot for addressing my comments! This looks good from my side now. 🙂
I propose leaving this PR open for a bit longer so that other contributors (in particular, @burgholzer) can also review the file.
|
Thanks again! @burgholzer would appreciate your review whenever you get a chance |
@burgholzer Bumping this in case missed Whenever you get time |
|
Thanks for the ping. This is still in my pile of reviews. I'll try to get to it today 👍🏻 |
Thanks for the update! Really appreciate you fitting this into your review pile |
burgholzer
left a comment
There was a problem hiding this comment.
Thanks @CodeMaverick2 for the initial draft here.
I gave this a fairly thorough review now. Please don't be overwhelmed by the number of comments that you will find inline. I tried to keep them as small an isolated as possible.
Overall, this feels like it definitely needs a bit of work to become useful. However, it seems like a solid start. I hope the comments help you to improve this further.
|
@burgholzer Addressed all your review comments removed redundant/prek-enforced sections, split code blocks into separate cells, added missing info (QIR, free-threading, Stable ABI, label-based testing, version-specific nox), and pointed to config files instead of duplicating rules. |
…ck2/core into aiToolingInstructions
|
@burgholzer Sorry about that missed 2 comments that were resolved without being addressed. |
Description -
Summary
Format
Fixes #1459
Checklist: