-
-
Notifications
You must be signed in to change notification settings - Fork 3
🚀 Clear assertion greyed-out lines on restart and highlight issue locations #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 105 commits
6fd5af1
8accf50
f4b0038
f7f27bd
0cca5ca
a5c3eca
5222682
7e82180
e4155c4
64de683
732ca9b
1e99c96
88de5e5
057b5dd
1bed4cc
cc2c09b
ad1fe09
cd4dba9
c3ca4b9
e43e740
36fdd37
aa92b5f
051fd1e
261d3b0
f6a5878
8018667
3dbd364
2cd3395
135fd94
b50cab1
bbc0cbb
ec901ce
1d1d848
ebe4cec
4b50146
465d447
50da634
7398f50
ea89e07
5d3f383
e8e9f40
ffe1a38
817e49e
c6b102f
1cefe3e
e10b1a0
ceaedcf
52ad47a
84c38f1
0d12f43
3ca8940
543bd22
9f13bd2
4ff44db
8e3b801
d1c343e
59680cb
5532817
b6e4152
ac21598
3e02a97
a7b5ce1
c8b03ee
59af8a0
687bc9b
ddc8b45
4e67409
7308dab
42a4bcf
86cc5c9
5160144
7e0c3df
68a8ffe
a7c6b72
8ef979f
83e928a
47edfc0
7b8fa09
ec64afd
32d14d8
b734fc1
92f4b4b
81801fa
e151e5d
d5cd2e7
ff0e4b3
f2d9c9d
8d6d7f0
fbb9bd1
3653c60
4bb141e
62ea2cc
9563c25
4c34277
ccfd5bb
8663fbe
c256690
cf270eb
489592b
4de1403
29607af
5a7413f
9d98879
a8c25e2
15bb5d9
175bb08
f53a848
d406d13
65f230c
55ad6b9
3169e22
090de19
c6faa23
b2c0b2b
6b15941
6fec6a9
af49c19
03920d7
efbcd5c
160c294
70897c1
4695b89
7e40ed9
9349194
2f77e27
6b9c1d7
c1eaccd
fa522a6
1f5e0ca
0e6bfa8
09f5ace
4f3e00d
f2d905c
819d0f4
a70891c
dd89f76
5822fbd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,8 @@ | |
| Diagnostics, | ||
| ErrorCause, | ||
| ErrorCauseType, | ||
| LoadResult, | ||
| Result, | ||
|
Comment on lines
21
to
23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# First, let's look at the __init__.py file to see the imports and __all__ list
cat -n python/mqt/debugger/__init__.py | head -50Repository: munich-quantum-toolkit/debugger Length of output: 1518 🏁 Script executed: #!/bin/bash
# Check if check/result_checker.py exists and contains a Result class
find . -name "result_checker.py" -type fRepository: munich-quantum-toolkit/debugger Length of output: 120 🏁 Script executed: #!/bin/bash
# Search for Result definitions in the codebase
rg -n "class Result" --type py -g '!__pycache__'Repository: munich-quantum-toolkit/debugger Length of output: 135 🏁 Script executed: #!/bin/bash
# Search for Result enum definitions
rg -n "class Result.*Enum|Result.*=.*Enum" --type py -g '!__pycache__'Repository: munich-quantum-toolkit/debugger Length of output: 57 🏁 Script executed: #!/bin/bash
# Find pydebugger module/binding to see Result definition
find . -name "pydebugger*" -type f | grep -E "\.(py|pyi|pyx)$"Repository: munich-quantum-toolkit/debugger Length of output: 111 🏁 Script executed: #!/bin/bash
# Check if pydebugger is a compiled module binding - look for .pyi stubs
find . -name "*.pyi" | head -20Repository: munich-quantum-toolkit/debugger Length of output: 146 🏁 Script executed: #!/bin/bash
# Read the result_checker.py to understand the Result class
cat -n python/mqt/debugger/check/result_checker.py | head -80Repository: munich-quantum-toolkit/debugger Length of output: 3164 🏁 Script executed: #!/bin/bash
# Search for actual usage of "from mqt.debugger import Result"
rg -n "from mqt.debugger import.*Result" --type py -g '!__pycache__'Repository: munich-quantum-toolkit/debugger Length of output: 57 🏁 Script executed: #!/bin/bash
# Search for mqt.debugger.Result usage
rg -n "mqt\.debugger\.Result" --type py -g '!__pycache__'Repository: munich-quantum-toolkit/debugger Length of output: 305 🏁 Script executed: #!/bin/bash
# Check the pydebugger.pyi stub file to see Result definition
cat -n python/mqt/debugger/pydebugger.pyi | grep -A 20 "class Result"Repository: munich-quantum-toolkit/debugger Length of output: 842 🏁 Script executed: #!/antml:thinking]
This will show me the actual Result definition from the type stub file, which should clarify whether it's an Enum or similar and what properties it has.Repository: munich-quantum-toolkit/debugger Length of output: 143 🏁 Script executed: #!/bin/bash
# Look for the full Result definition in pydebugger.pyi
cat python/mqt/debugger/pydebugger.pyi | grep -A 30 "class Result"Repository: munich-quantum-toolkit/debugger Length of output: 1012 🏁 Script executed: #!/bin/bash
# Check if Result enum and Result class are imported together anywhere
rg -n "from.*Result|import.*Result" --type py -g '!__pycache__' | head -30Repository: munich-quantum-toolkit/debugger Length of output: 164 🏁 Script executed: #!/antml:thinking]
I want to see if anywhere in the codebase both Result types are used in the same file, which would indicate a real conflict.Repository: munich-quantum-toolkit/debugger Length of output: 116 🏁 Script executed: #!/bin/bash
# Check what LoadResult is (since it's also exported)
cat python/mqt/debugger/pydebugger.pyi | grep -A 15 "class LoadResult"Repository: munich-quantum-toolkit/debugger Length of output: 576 🏁 Script executed: #!/an/bash
# Look for any type hints or usage that shows both Result types in same context
rg -B 5 -A 5 "check\.Result|result_checker\.Result" --type py -g '!__pycache__'Repository: munich-quantum-toolkit/debugger Length of output: 57 🏁 Script executed: #!/bin/bash
# Check if check/__init__.py exports Result and if it would create confusion
cat python/mqt/debugger/check/__init__.pyRepository: munich-quantum-toolkit/debugger Length of output: 756 🏁 Script executed: #!/an/bash
# Look for any imports that combine both Result types in one file
rg -l "from.*pydebugger.*Result|from.*result_checker.*Result" --type py | while read f; do
echo "=== $f ==="
grep -n "import.*Result" "$f"
doneRepository: munich-quantum-toolkit/debugger Length of output: 172 🏁 Script executed: #!/bin/bash
# Verify if any code imports both Result types in the same file
find python -name "*.py" -type f -exec grep -l "from mqt.debugger import" {} \; | while read f; do
if grep -q "LoadResult\|Result" "$f" && grep -q "from.*check.*Result" "$f"; then
echo "=== $f ==="
grep -n "import\|from" "$f" | grep -E "LoadResult|Result"
fi
doneRepository: munich-quantum-toolkit/debugger Length of output: 161 🏁 Script executed: #!/bin/bash
# Check the actual imports in launch_dap_message.py and restart_dap_message.py where Result.OK is used
head -30 python/mqt/debugger/dap/messages/launch_dap_message.py | grep -E "^from|^import"Repository: munich-quantum-toolkit/debugger Length of output: 260 🏁 Script executed: #!/bin/bash
# Check LoadResult to see if it provides context about Result enum usage
head -80 python/mqt/debugger/pydebugger.pyi | grep -A 10 "LoadResult"Repository: munich-quantum-toolkit/debugger Length of output: 57 🏁 Script executed: #!/antml:thinking]
I want to understand the relationship between LoadResult and Result to see if the naming is intentional and if renaming would cause issues.Repository: munich-quantum-toolkit/debugger Length of output: 116 🏁 Script executed: #!/bin/bash
# Check if there are any type hints or documentation that explain why Result is exported at top level
grep -r "LoadResult\|Result" python/mqt/debugger/__init__.py -B 2 -A 2Repository: munich-quantum-toolkit/debugger Length of output: 293 Consider renaming The new Renaming the enum to 🤖 Prompt for AI Agents |
||
| SimulationState, | ||
| Statevector, | ||
| Variable, | ||
|
|
@@ -33,6 +35,8 @@ | |
| "Diagnostics", | ||
| "ErrorCause", | ||
| "ErrorCauseType", | ||
| "LoadResult", | ||
| "Result", | ||
| "SimulationState", | ||
| "Statevector", | ||
| "Variable", | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.