⬆️ Adopt new NAComputation in NASP tool, Isolate NALAC, Remove YAML Dependency#608
Merged
burgholzer merged 13 commits intomainfrom Mar 11, 2025
Merged
⬆️ Adopt new NAComputation in NASP tool, Isolate NALAC, Remove YAML Dependency#608burgholzer merged 13 commits intomainfrom
NAComputation in NASP tool, Isolate NALAC, Remove YAML Dependency#608burgholzer merged 13 commits intomainfrom
Conversation
7bacb7d to
28b1116
Compare
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
dcd4e31 to
98b2a22
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=======================================
+ Coverage 90.8% 91.1% +0.2%
=======================================
Files 94 104 +10
Lines 10761 10938 +177
Branches 1830 1862 +32
=======================================
+ Hits 9780 9966 +186
+ Misses 981 972 -9
🚀 New features to boost your workflow:
|
98b2a22 to
0226f9e
Compare
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
0226f9e to
730a9e5
Compare
burgholzer
approved these changes
Mar 11, 2025
Member
burgholzer
left a comment
There was a problem hiding this comment.
I fixed up a couple of things and updated MQT Core again.
Now everything is green and as clean as ever ✨
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the
NAComputationhas been refactored in MQT Core, the code in MQT QMAP is not compatible with the new structure anymore. As a consequence, this PR isolates everything related toNALAC, i.e., bundles the oldNAComputationdirectly with NALAC. While doing that, this PR removes the YAML dependency used in NALAC and replaces every use of YAML by the use of JSON.The tool NASP is adapted to the new
NAComputation. Additionally, also here the dependency YAML is replaced by the use of JSON.