Skip to content

⬆️ Adopt new NAComputation in NASP tool, Isolate NALAC, Remove YAML Dependency#608

Merged
burgholzer merged 13 commits intomainfrom
refactor-na-computation
Mar 11, 2025
Merged

⬆️ Adopt new NAComputation in NASP tool, Isolate NALAC, Remove YAML Dependency#608
burgholzer merged 13 commits intomainfrom
refactor-na-computation

Conversation

@ystade
Copy link
Collaborator

@ystade ystade commented Mar 10, 2025

Description

After the NAComputation has been refactored in MQT Core, the code in MQT QMAP is not compatible with the new structure anymore. As a consequence, this PR isolates everything related to NALAC, i.e., bundles the old NAComputation directly with NALAC. While doing that, this PR removes the YAML dependency used in NALAC and replaces every use of YAML by the use of JSON.

The tool NASP is adapted to the new NAComputation. Additionally, also here the dependency YAML is replaced by the use of JSON.

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer force-pushed the refactor-na-computation branch from dcd4e31 to 98b2a22 Compare March 10, 2025 22:53
@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 98.13953% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.1%. Comparing base (08b6a25) to head (730a9e5).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
include/na/nalac/datastructures/NADefinitions.hpp 93.6% 3 Missing ⚠️
src/na/nalac/NAMapper.cpp 91.3% 2 Missing ⚠️
src/na/nasp/CodeGenerator.cpp 95.5% 2 Missing ⚠️
include/na/nasp/Solver.hpp 88.8% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #608     +/-   ##
=======================================
+ Coverage   90.8%   91.1%   +0.2%     
=======================================
  Files         94     104     +10     
  Lines      10761   10938    +177     
  Branches    1830    1862     +32     
=======================================
+ Hits        9780    9966    +186     
+ Misses       981     972      -9     
Flag Coverage Δ
cpp 90.8% <98.1%> (+0.2%) ⬆️
python 96.5% <100.0%> (+0.2%) ⬆️
Files with missing lines Coverage Δ
include/hybridmap/MoveToAodConverter.hpp 100.0% <ø> (ø)
include/hybridmap/NeutralAtomArchitecture.hpp 92.8% <100.0%> (-0.2%) ⬇️
include/na/nalac/NAMapper.hpp 100.0% <100.0%> (ø)
include/na/nalac/datastructures/Architecture.hpp 100.0% <100.0%> (ø)
include/na/nalac/datastructures/Configuration.hpp 100.0% <ø> (ø)
include/na/nalac/datastructures/NAComputation.hpp 100.0% <100.0%> (ø)
...ac/datastructures/operations/NAGlobalOperation.hpp 100.0% <100.0%> (ø)
...lac/datastructures/operations/NALocalOperation.hpp 100.0% <100.0%> (ø)
...na/nalac/datastructures/operations/NAOperation.hpp 100.0% <100.0%> (ø)
...datastructures/operations/NAShuttlingOperation.hpp 100.0% <100.0%> (ø)
... and 18 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@burgholzer burgholzer force-pushed the refactor-na-computation branch from 98b2a22 to 0226f9e Compare March 10, 2025 23:35
@burgholzer burgholzer added this to MQT Mar 10, 2025
@github-project-automation github-project-automation bot moved this to In Progress in MQT Mar 10, 2025
@burgholzer burgholzer added dependencies Pull requests that update a dependency file usability Anything related to usability c++ Anything related to C++ code code quality Anything related to code quality and code style. labels Mar 10, 2025
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer force-pushed the refactor-na-computation branch from 0226f9e to 730a9e5 Compare March 10, 2025 23:45
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed up a couple of things and updated MQT Core again.
Now everything is green and as clean as ever ✨

@burgholzer burgholzer merged commit f56efbf into main Mar 11, 2025
31 checks passed
@burgholzer burgholzer deleted the refactor-na-computation branch March 11, 2025 01:09
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQT Mar 11, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQT Compilation Mar 11, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 15, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code code quality Anything related to code quality and code style. dependencies Pull requests that update a dependency file usability Anything related to usability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants