🏗️ Remove SolverFactory to entirely isolate NALAC#609
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
=======================================
- Coverage 91.1% 91.0% -0.1%
=======================================
Files 104 103 -1
Lines 10932 10900 -32
Branches 1862 1861 -1
=======================================
- Hits 9960 9928 -32
Misses 972 972
🚀 New features to boost your workflow:
|
burgholzer
approved these changes
Mar 11, 2025
Member
burgholzer
left a comment
There was a problem hiding this comment.
Just two tiny comments about the include style.
And it would be nice to get that codecov check green, if easily possible.
Co-authored-by: Lukas Burgholzer <burgholzer@me.com> Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>
Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>
Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>
Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NASP had still a dependency on NALAC. The only part where this was used was the solver factory. Sine this was not super useful anyways, the solver factory is removed together with the dependency on NALAC.
Checklist: