Skip to content

🏗️ Remove SolverFactory to entirely isolate NALAC#609

Merged
ystade merged 7 commits intomainfrom
isolate-nalac
Mar 11, 2025
Merged

🏗️ Remove SolverFactory to entirely isolate NALAC#609
ystade merged 7 commits intomainfrom
isolate-nalac

Conversation

@ystade
Copy link
Collaborator

@ystade ystade commented Mar 11, 2025

Description

NASP had still a dependency on NALAC. The only part where this was used was the solver factory. Sine this was not super useful anyways, the solver factory is removed together with the dependency on NALAC.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@github-project-automation github-project-automation bot moved this to In Progress in MQT Compilation Mar 11, 2025
@ystade ystade added the dependencies Pull requests that update a dependency file label Mar 11, 2025
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.0%. Comparing base (f56efbf) to head (ece67e9).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #609     +/-   ##
=======================================
- Coverage   91.1%   91.0%   -0.1%     
=======================================
  Files        104     103      -1     
  Lines      10932   10900     -32     
  Branches    1862    1861      -1     
=======================================
- Hits        9960    9928     -32     
  Misses       972     972             
Flag Coverage Δ
cpp 90.8% <100.0%> (-0.1%) ⬇️
python 96.5% <ø> (+<0.1%) ⬆️
Files with missing lines Coverage Δ
include/na/nasp/Solver.hpp 95.0% <ø> (ø)
src/na/nasp/Solver.cpp 93.9% <100.0%> (+0.2%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@burgholzer burgholzer added this to MQT Mar 11, 2025
@github-project-automation github-project-automation bot moved this to In Progress in MQT Mar 11, 2025
@burgholzer burgholzer added the refactor Anything related to code refactoring label Mar 11, 2025
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two tiny comments about the include style.

And it would be nice to get that codecov check green, if easily possible.

ystade and others added 3 commits March 11, 2025 15:54
Co-authored-by: Lukas Burgholzer <burgholzer@me.com>
Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>
@ystade ystade enabled auto-merge March 11, 2025 14:55
ystade added 3 commits March 11, 2025 16:23
Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>
Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>
Signed-off-by: Yannick Stade <100073938+ystade@users.noreply.github.com>
@ystade ystade merged commit ae6f34f into main Mar 11, 2025
31 checks passed
@ystade ystade deleted the isolate-nalac branch March 11, 2025 16:32
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQT Compilation Mar 11, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQT Mar 11, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 15, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file refactor Anything related to code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants