Skip to content

⬆️ Update prek checks#316

Merged
burgholzer merged 3 commits intomainfrom
prek
Feb 2, 2026
Merged

⬆️ Update prek checks#316
burgholzer merged 3 commits intomainfrom
prek

Conversation

@denialhaag
Copy link
Member

@denialhaag denialhaag commented Feb 2, 2026

Description

This PR updates .pre-commit-config.yml to make use of prek's priority feature.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag self-assigned this Feb 2, 2026
@denialhaag denialhaag added dependencies Pull requests that update a dependency file pre-commit labels Feb 2, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Summary by CodeRabbit

Chores

  • Updated CI/CD pipeline configurations with improved default settings and clearer documentation
  • Enhanced automated code quality checks with new validation rules for consistency
  • Reorganized pre-commit hooks with priority-based execution for improved development workflow performance
  • Integrated additional security scanning and code formatting tools into the verification process

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

This PR updates GitHub Actions workflow configurations and pre-commit hooks. The macOS workflow removes MLIR references from compiler documentation. The Ubuntu workflow capitalizes the workflow name and updates the default runner to ubuntu-24.04. The pre-commit configuration introduces priority-based hook execution, adds new checks (capitalization rules, BibTeX tidying, security analysis with zizmor), and reorganizes existing hooks into a multi-tier structure.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/reusable-cpp-tests-macos.yml, .github/workflows/reusable-cpp-tests-ubuntu.yml
Removed "including MLIR" phrasing from clang-XX compiler descriptions, capitalized Ubuntu in workflow name, updated ubuntu-latest default to ubuntu-24.04 with simplified allowed runner values.
Pre-commit Configuration
.pre-commit-config.yaml
Introduced priority levels (0–2) for hooks to control execution order, added new hooks for capitalization checks and BibTeX tidying, integrated zizmor for security scanning, reorganized and commented hook sections for clarity.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

continuous integration

Suggested reviewers

  • burgholzer

Poem

🐰 A hop through configs, priorities aligned,
Pre-commit hooks dance in order refined,
Ubuntu ascends, capitalized and grand,
MLIR fades as CI takes its stand,
Zizmor now watches with security's keen eye! 🔍

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title references updating 'prek' checks, which is the primary subject of the PR, but is vague about the specific changes (priority features). Consider clarifying the title to mention the priority feature aspect, e.g., 'Add priority levels to pre-commit hooks' or 'Update pre-commit config to use prek priorities'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description states the main purpose but lacks detail about motivation, context, and dependencies. Most checklist items are marked as not applicable without clear justification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch prek

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@denialhaag denialhaag requested a review from burgholzer February 2, 2026 02:34
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.pre-commit-config.yaml:
- Around line 17-29: Update the section header "Priority 0: Fast validation and
independent fixers" so it no longer implies all hooks are priority 0;
specifically remove "independent fixers" (or change to "Priority 0 and 1: Fast
validation") to reflect that hooks like end-of-file-fixer and
trailing-whitespace are priority 1 while check-merge-conflict is priority 0;
locate the header string and the hook ids end-of-file-fixer and
trailing-whitespace to confirm the wording change matches the actual priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pre-commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants