Skip to content

fix(AppActions): File > Exit causes crash#582

Merged
Aurumaker72 merged 1 commit intomainfrom
close-action-crashing
Mar 30, 2026
Merged

fix(AppActions): File > Exit causes crash#582
Aurumaker72 merged 1 commit intomainfrom
close-action-crashing

Conversation

@Aurumaker72
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 30, 2026 16:43
@Aurumaker72 Aurumaker72 merged commit 4f524c6 into main Mar 30, 2026
10 of 11 checks passed
@Aurumaker72 Aurumaker72 deleted the close-action-crashing branch March 30, 2026 16:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a crash in the Win32 view when invoking File > Exit by routing shutdown through the main window’s normal close path instead of destroying the window directly.

Changes:

  • Replace DestroyWindow(g_main_ctx.hwnd) with PostMessage(..., WM_CLOSE, ...) in the File/Exit action handler.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants