Skip to content

discogs_importer: subtracks in Discogs to separete tracks in Musicbrainz #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hirokobayashi wants to merge 4 commits into
base: master
Choose a base branch
from
Open

discogs_importer: subtracks in Discogs to separete tracks in Musicbrainz #281

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a211ace
discogs_importer: Change subtracks in Discogs to separete tracks in M…
hirokobayashi Jun 18, 2020
27ebcc8
Fix linter error
hirokobayashi Jun 19, 2020
26baf96
Fix linter error
hirokobayashi Jun 19, 2020
5207903
Fix linter error
hirokobayashi Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions discogs_importer.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,12 +582,13 @@ function parseDiscogsRelease(data) {
}

// Inspect tracks
let tracks = [];
//let tracks = [];

let heading = '';
let releaseNumber = 1;
let lastPosition = 0;
$.each(discogsRelease.tracklist, function (index, discogsTrack) {
let tracks = [];
if (discogsTrack.type_ == 'heading') {
heading = discogsTrack.title;
return;
Expand Down Expand Up @@ -629,14 +630,19 @@ function parseDiscogsRelease(data) {
if (subtrack.type_ != 'track') {
return;
}
let track_new = new Object();
if (subtrack.duration) {
track_new.duraction = MBImport.hmsToMilliSeconds(subtrack.duration);
subtrack_total_duration += MBImport.hmsToMilliSeconds(subtrack.duration);
}
if (subtrack.title) {
track_new.title = `${track.title}: ${subtrack.title}`;
track_new.artist_credit = track.artist_credit;
subtrack_titles.push(subtrack.title);
} else {
subtrack_titles.push('[unknown]');
}
tracks.push(track_new);
});
if (subtrack_titles.length) {
if (track.title) {
Expand Down Expand Up @@ -725,7 +731,13 @@ function parseDiscogsRelease(data) {

// Trackposition is empty e.g. for release title
if (trackPosition != '' && trackPosition != null) {
release.discs[discindex].tracks.push(track);
if (tracks.length > 0) {
for (var i = 0; i < tracks.length; i++) {
release.discs[discindex].tracks.push(tracks[i]);
}
} else {
release.discs[discindex].tracks.push(track);
}
}

if (buggyTrackNumber && !release.maybe_buggy) {
Expand Down