Skip to content

bandcamp_importer: enable MB Release links on Discography pages (release lists) #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zas merged 5 commits into from
Apr 22, 2025
Merged

bandcamp_importer: enable MB Release links on Discography pages (release lists) #609

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a95a8d1
bandcamp_importer: enable MB Release links on Discography pages (rele…
arsinclair Apr 21, 2025
755cb5e
chore: fix lint errors
arsinclair Apr 21, 2025
6776bbe
Merge branch 'master' into feat/implement-discography-page-linking
arsinclair Apr 21, 2025
aff7ad5
chore: update version number to 2025.04.22.1
arsinclair Apr 21, 2025
31c2503
chore: re-reran prettier script after dependency upgrades
arsinclair Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
229 changes: 126 additions & 103 deletions bandcamp_importer.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
// ==UserScript==
// @name Import Bandcamp releases to MusicBrainz
// @description Add a button on Bandcamp's album pages to open MusicBrainz release editor with pre-filled data for the selected release
// @version 2024.10.17.1
// @version 2025.04.22.1
// @namespace http://userscripts.org/users/22504
// @downloadURL https://raw.github.com/murdos/musicbrainz-userscripts/master/bandcamp_importer.user.js
// @updateURL https://raw.github.com/murdos/musicbrainz-userscripts/master/bandcamp_importer.user.js
// @include /^https?://[^/]+/(?:album|track)/[^/]+\/?$/
// @include /^https?://web\.archive\.org/web/\d+/https?://[^/]+/(?:album|track)/[^/]+\/?$/
// @include /^https:\/\/[^/]+(?:\/(?:album|track)\/[^/]+\/?|\/music\/?|\/?)$/
// @include /^https?:\/\/web\.archive\.org\/web\/\d+\/https?:\/\/[^/]+(?:\/(?:album|track)\/[^/]+\/?|\/music\/?|\/?)$/
// @require https://ajax.googleapis.com/ajax/libs/jquery/2.2.4/jquery.min.js
// @require lib/mbimport.js
// @require lib/logger.js
Expand Down Expand Up @@ -141,7 +141,7 @@
if (numtracks > 0 && numtracks > showntracks) {
// display a warning if tracks in download differs from tracks shown
$('h2.trackTitle').append(
`<p style="font-size: 70%; font-style: italic; margin: 0.1em 0;">Warning: ${numtracks} vs ${showntracks} tracks</p>`,
`<p style="font-size: 70%; font-style: italic; margin: 0.1em 0;">Warning: ${numtracks} vs ${showntracks} tracks</p>`

Check failure on line 144 in bandcamp_importer.user.js

View workflow job for this annotation

GitHub Actions / lint checks 

Insert `,`
);

// append unknown tracks to the release
Expand Down Expand Up @@ -299,117 +299,140 @@
*/
if (!unsafeWindow.TralbumData) return;
/***/
let mblinks = new MBLinks('BCI_MBLINKS_CACHE');

MBImportStyle();
const isDiscographyPage = unsafeWindow.TralbumData.url && !!unsafeWindow.TralbumData.url.match(/\/music\/?$/);

let mblinks = new MBLinks('BCI_MBLINKS_CACHE');
if (isDiscographyPage) {
const hostname = unsafeWindow.TralbumData.url.replace('/music', '');

let release = BandcampImport.retrieveReleaseInfo();

// add MB artist link
let root_url = release.url.match(/^(https?:\/\/[^/]+)/)[1].split('?')[0];
let label_url = '';

mblinks.searchAndDisplayMbLink(
root_url,
'label',
function (link) {
$('p#band-name-location span.title').append(link);
},
`label:${root_url}`,
);
const labelback = document.querySelector('a.back-to-label-link');
if (labelback) {
const labelbacklink = labelback.getAttribute('href');
if (labelbacklink) {
label_url = labelbacklink
.match(/^(https?:\/\/[^/]+)/)[1]
.split('?')[0]
.fix_bandcamp_url();
mblinks.searchAndDisplayMbLink(
label_url,
'label',
function (link) {
$('a.back-to-label-link span.back-link-text').append(link);
},
`label:${label_url}`,
);
$('ol#music-grid > li > a').each(function () {
const $link = $(this);
const bandcampReleaseUrl = $link.attr('href');

if (bandcampReleaseUrl && bandcampReleaseUrl.match(/^(\/album|\/track)/)) {
const full_url = hostname + bandcampReleaseUrl;

mblinks.searchAndDisplayMbLink(
full_url,
'release',
function (link) {
$('p.title', $link).prepend(link);
},
`release:${full_url}`

Check failure on line 322 in bandcamp_importer.user.js

View workflow job for this annotation

GitHub Actions / lint checks 

Insert `,`
);
}
});
} else {
MBImportStyle();

let release = BandcampImport.retrieveReleaseInfo();

// add MB artist link
let root_url = release.url.match(/^(https?:\/\/[^/]+)/)[1].split('?')[0];
let label_url = '';

mblinks.searchAndDisplayMbLink(
root_url,
'label',
function (link) {
$('p#band-name-location span.title').append(link);
},
`label:${root_url}`

Check failure on line 341 in bandcamp_importer.user.js

View workflow job for this annotation

GitHub Actions / lint checks 

Insert `,`
);
const labelback = document.querySelector('a.back-to-label-link');
if (labelback) {
const labelbacklink = labelback.getAttribute('href');
if (labelbacklink) {
label_url = labelbacklink
.match(/^(https?:\/\/[^/]+)/)[1]
.split('?')[0]
.fix_bandcamp_url();
mblinks.searchAndDisplayMbLink(
label_url,
'label',
function (link) {
$('a.back-to-label-link span.back-link-text').append(link);
},
`label:${label_url}`

Check failure on line 357 in bandcamp_importer.user.js

View workflow job for this annotation

GitHub Actions / lint checks 

Insert `,`
);
}
}
}

if (release.artist_credit.length == 1) {
// try to get artist's mbid from cache
let artist_mbid = mblinks.resolveMBID(root_url);
if (artist_mbid) {
release.artist_credit[0].mbid = artist_mbid;
if (release.artist_credit.length == 1) {
// try to get artist's mbid from cache
let artist_mbid = mblinks.resolveMBID(root_url);
if (artist_mbid) {
release.artist_credit[0].mbid = artist_mbid;
}
}
}

// try to get label mbid from cache
let label_mbid = '';
let label_name = '';
if (label_url) {
label_mbid = mblinks.resolveMBID(`label:${label_url}`);
label_name = BandcampImport.getlabelname();
} else {
label_mbid = mblinks.resolveMBID(`label:${root_url}`);
if (label_mbid) label_name = $('p#band-name-location span.title').text().trim();
}
if (label_mbid || label_name) {
if (release.labels.length == 0) {
release.labels.push({
name: '',
mbid: '',
catno: 'none',
// try to get label mbid from cache
let label_mbid = '';
let label_name = '';
if (label_url) {
label_mbid = mblinks.resolveMBID(`label:${label_url}`);
label_name = BandcampImport.getlabelname();
} else {
label_mbid = mblinks.resolveMBID(`label:${root_url}`);
if (label_mbid) label_name = $('p#band-name-location span.title').text().trim();
}
if (label_mbid || label_name) {
if (release.labels.length == 0) {
release.labels.push({
name: '',
mbid: '',
catno: 'none',
});
}
release.labels[0].name = label_name;
release.labels[0].mbid = label_mbid;
}

BandcampImport.insertLink(release);
LOGGER.info('Parsed release: ', release);

if (release.type == 'track') {
mblinks.searchAndDisplayMbLink(root_url, 'artist', function (link) {
$('div#name-section h3 span:last').before(link);
});
// add MB links to parent album
mblinks.searchAndDisplayMbLink(release.parent_album_url, 'release', function (link) {
$('div#name-section h3 span:first').before(link);
});
} else {
mblinks.searchAndDisplayMbLink(root_url, 'artist', function (link) {
$('div#name-section h3 span:first').before(link);
});
// add MB release links to album or single
mblinks.searchAndDisplayMbLink(release.url, 'release', function (link) {
$('div#name-section h3 span:first').after(link);
});
}
release.labels[0].name = label_name;
release.labels[0].mbid = label_mbid;
}

BandcampImport.insertLink(release);
LOGGER.info('Parsed release: ', release);
// append a comma after each tag to ease cut'n'paste to MB
$('div.tralbum-tags a:not(:last-child).tag').after(', ');

if (release.type == 'track') {
mblinks.searchAndDisplayMbLink(root_url, 'artist', function (link) {
$('div#name-section h3 span:last').before(link);
});
// add MB links to parent album
mblinks.searchAndDisplayMbLink(release.parent_album_url, 'release', function (link) {
$('div#name-section h3 span:first').before(link);
});
} else {
mblinks.searchAndDisplayMbLink(root_url, 'artist', function (link) {
$('div#name-section h3 span:first').before(link);
});
// add MB release links to album or single
mblinks.searchAndDisplayMbLink(release.url, 'release', function (link) {
$('div#name-section h3 span:first').after(link);
});
}
// append a link to the full size image
const tralbumArt = document.querySelector('div#tralbumArt');
const fullsizeimageurl = tralbumArt.querySelector('a').getAttribute('href').replace('_10', '_0');
tralbumArt.insertAdjacentHTML(
'afterend',
`<div id='bci_link'><a class='custom-color' href='${fullsizeimageurl}' title='Open original image in a new tab (Bandcamp importer)' target='_blank'>Original image</a></div>`

Check failure on line 421 in bandcamp_importer.user.js

View workflow job for this annotation

GitHub Actions / lint checks 

Insert `,`
);

// append a comma after each tag to ease cut'n'paste to MB
$('div.tralbum-tags a:not(:last-child).tag').after(', ');

// append a link to the full size image
const tralbumArt = document.querySelector('div#tralbumArt');
const fullsizeimageurl = tralbumArt.querySelector('a').getAttribute('href').replace('_10', '_0');
tralbumArt.insertAdjacentHTML(
'afterend',
`<div id='bci_link'><a class='custom-color' href='${fullsizeimageurl}' title='Open original image in a new tab (Bandcamp importer)' target='_blank'>Original image</a></div>`,
);

const bci_link = document.querySelector('div#bci_link');
bci_link.style.paddingTop = '0.5em';
bci_link.style.textAlign = 'right';
bci_link.querySelector('a').style.fontWeight = 'bold';
const upc = unsafeWindow.TralbumData.current.upc;
if (typeof upc != 'undefined' && upc !== null) {
document.querySelector('div #trackInfoInner').insertAdjacentHTML(
'beforeend',
`<div id="mbimport_upc" style="margin-bottom: 2em; font-size: smaller;">UPC: ${upc}<br/>
const bci_link = document.querySelector('div#bci_link');
bci_link.style.paddingTop = '0.5em';
bci_link.style.textAlign = 'right';
bci_link.querySelector('a').style.fontWeight = 'bold';
const upc = unsafeWindow.TralbumData.current.upc;
if (typeof upc != 'undefined' && upc !== null) {
document.querySelector('div #trackInfoInner').insertAdjacentHTML(
'beforeend',
`<div id="mbimport_upc" style="margin-bottom: 2em; font-size: smaller;">UPC: ${upc}<br/>
Import: <a href="https://harmony.pulsewidth.org.uk/release?url=${encodeURIComponent(release.url)}&category=default">Harmony</a>
| <a href="https://atisket.pulsewidth.org.uk/?upc=${upc}">a-tisket</a></div>`,
);
| <a href="https://atisket.pulsewidth.org.uk/?upc=${upc}">a-tisket</a></div>`

Check failure on line 434 in bandcamp_importer.user.js

View workflow job for this annotation

GitHub Actions / lint checks 

Insert `,`
);
}
}
});
Loading