murrant · murrant · Sep 3, 2025 · Sep 3, 2025 · Sep 3, 2025 · Sep 4, 2025
diff --git a/composer.json b/composer.json
@@ -67,10 +67,12 @@
         "laravel/dusk": "^8.2.2",
         "mockery/mockery": "^1.6",
         "nunomaduro/collision": "^8.6",
+        "pestphp/pest": "^3.8 || ^4.0",
+        "pestphp/pest-plugin-laravel": "^3.0 || ^4.0",
         "php-parallel-lint/php-parallel-lint": "^1.1",
         "phpstan/phpstan-deprecation-rules": "^2.0",
         "phpstan/phpstan-mockery": "^2.0",
-        "phpunit/phpunit": "^11.5.3"
+        "phpunit/phpunit": "^11.5.33 || ^12.3.7"
     },
     "suggest": {
         "ext-gmp": "Used for browser push notifications",
@@ -86,6 +88,7 @@
         "preferred-install": "dist",
         "sort-packages": true,
         "allow-plugins": {
+            "pestphp/pest-plugin": true,
             "php-http/discovery": false
         }
     },

diff --git a/composer.lock b/composer.lock
diff --git a/phpstan.neon b/phpstan.neon
@@ -1,6 +1,5 @@
 includes:
     - phpstan-baseline.neon
-    - tests/phpstan/ignore-by-php-version.neon.php
     - vendor/larastan/larastan/extension.neon
     - vendor/phpstan/phpstan-mockery/extension.neon
 
@@ -20,7 +19,6 @@ parameters:
         - tests
 
     excludePaths:
-        - tests/phpstan/
         - tests/Unit/Data/KafkaDBStoreTest.php
         - LibreNMS/Data/Store/Kafka.php
 

diff --git a/tests/AddHostCliTest.php b/tests/AddHostCliTest.php
@@ -29,7 +29,7 @@
 use App\Models\Device;
 use Illuminate\Foundation\Testing\DatabaseTransactions;
 
-class AddHostCliTest extends DBTestCase
+final class AddHostCliTest extends DBTestCase
 {
     use DatabaseTransactions;
 

diff --git a/tests/AlertingTest.php b/tests/AlertingTest.php
@@ -30,7 +30,7 @@
 use RecursiveIteratorIterator;
 use RegexIterator;
 
-class AlertingTest extends TestCase
+final class AlertingTest extends TestCase
 {
     public function testJsonAlertCollection(): void
     {

diff --git a/tests/AuthHTTPTest.php b/tests/AuthHTTPTest.php
@@ -32,7 +32,7 @@
 use function strip_tags;
 use function strip_tags as strip_tags1;
 
-class AuthHTTPTest extends TestCase
+final class AuthHTTPTest extends TestCase
 {
     private $original_auth_mech;
     private $server;

diff --git a/tests/AuthSSOTest.php b/tests/AuthSSOTest.php
@@ -32,7 +32,7 @@
 use Illuminate\Support\Str;
 use LibreNMS\Authentication\LegacyAuth;
 
-class AuthSSOTest extends DBTestCase
+final class AuthSSOTest extends DBTestCase
 {
     use DatabaseTransactions;
 

diff --git a/tests/BasicApiTest.php b/tests/BasicApiTest.php
@@ -31,7 +31,7 @@
 use App\Models\User;
 use Illuminate\Foundation\Testing\DatabaseTransactions;
 
-class BasicApiTest extends DBTestCase
+final class BasicApiTest extends DBTestCase
 {
     use DatabaseTransactions;
 

diff --git a/tests/Browser/LoginTest.php b/tests/Browser/LoginTest.php
@@ -18,7 +18,7 @@
  * Class LoginTest
  */
 #[Group('browser')]
-class LoginTest extends DuskTestCase
+final class LoginTest extends DuskTestCase
 {
     use DatabaseTruncation;
     protected array $connectionsToTruncate = ['testing', 'testing_persistent'];

diff --git a/tests/CommonFunctionsTest.php b/tests/CommonFunctionsTest.php
@@ -33,7 +33,7 @@
 use LibreNMS\Util\StringHelpers;
 use LibreNMS\Util\Validate;
 
-class CommonFunctionsTest extends TestCase
+final class CommonFunctionsTest extends TestCase
 {
     public function testStrContains(): void
     {

diff --git a/tests/ConfigTest.php b/tests/ConfigTest.php
@@ -29,7 +29,7 @@
 use App\ConfigRepository;
 use App\Facades\LibrenmsConfig;
 
-class ConfigTest extends TestCase
+final class ConfigTest extends TestCase
 {
     private \ReflectionProperty $config;
 

diff --git a/tests/DBSetupTest.php b/tests/DBSetupTest.php
@@ -30,7 +30,7 @@
 use Illuminate\Support\Facades\DB;
 use LibreNMS\DB\Schema;
 
-class DBSetupTest extends DBTestCase
+final class DBSetupTest extends DBTestCase
 {
     protected $db_name;
     protected $connection = 'testing';

diff --git a/tests/DocsTest.php b/tests/DocsTest.php
@@ -29,7 +29,7 @@
 use PHPUnit\Framework\Attributes\Group;
 use Symfony\Component\Yaml\Yaml;
 
-class DocsTest extends TestCase
+final class DocsTest extends TestCase
 {
     private $hidden_pages = [
     ];

diff --git a/tests/Feature/Commands/TestConfigCommands.php b/tests/Feature/Commands/TestConfigCommands.php
@@ -29,7 +29,7 @@
 use App\Facades\LibrenmsConfig;
 use LibreNMS\Tests\InMemoryDbTestCase;
 
-class TestConfigCommands extends InMemoryDbTestCase
+final class TestConfigCommands extends InMemoryDbTestCase
 {
     public function testSetting(): void
     {

diff --git a/tests/Feature/SnmpTraps/AdvaAccThresholdCrossingAlertTest.php b/tests/Feature/SnmpTraps/AdvaAccThresholdCrossingAlertTest.php
@@ -26,7 +26,7 @@
 
 namespace LibreNMS\Tests\Feature\SnmpTraps;
 
-class AdvaAccThresholdCrossingAlertTest extends SnmpTrapTestCase
+final class AdvaAccThresholdCrossingAlertTest extends SnmpTrapTestCase
 {
     public function testAccThresholdTrap(): void
     {

diff --git a/tests/Feature/SnmpTraps/AdvaAttributeChangeTest.php b/tests/Feature/SnmpTraps/AdvaAttributeChangeTest.php
@@ -26,7 +26,7 @@
 
 namespace LibreNMS\Tests\Feature\SnmpTraps;
 
-class AdvaAttributeChangeTest extends SnmpTrapTestCase
+final class AdvaAttributeChangeTest extends SnmpTrapTestCase
 {
     public function testSyslogIPVersionModified(): void
     {

diff --git a/tests/Feature/SnmpTraps/AdvaDyingGaspTrapTest.php b/tests/Feature/SnmpTraps/AdvaDyingGaspTrapTest.php
@@ -28,7 +28,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class AdvaDyingGaspTrapTest extends SnmpTrapTestCase
+final class AdvaDyingGaspTrapTest extends SnmpTrapTestCase
 {
     public function testDyingGasp(): void
     {

diff --git a/tests/Feature/SnmpTraps/AdvaNetThresholdCrossingAlertTest.php b/tests/Feature/SnmpTraps/AdvaNetThresholdCrossingAlertTest.php
@@ -26,7 +26,7 @@
 
 namespace LibreNMS\Tests\Feature\SnmpTraps;
 
-class AdvaNetThresholdCrossingAlertTest extends SnmpTrapTestCase
+final class AdvaNetThresholdCrossingAlertTest extends SnmpTrapTestCase
 {
     public function testNetThresholdTrap(): void
     {

diff --git a/tests/Feature/SnmpTraps/AdvaNetworkElementAlmTrapTest.php b/tests/Feature/SnmpTraps/AdvaNetworkElementAlmTrapTest.php
@@ -28,7 +28,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class AdvaNetworkElementAlmTrapTest extends SnmpTrapTestCase
+final class AdvaNetworkElementAlmTrapTest extends SnmpTrapTestCase
 {
     public function testElementAlarmCleared(): void
     {

diff --git a/tests/Feature/SnmpTraps/AdvaObjectCreationTest.php b/tests/Feature/SnmpTraps/AdvaObjectCreationTest.php
@@ -26,7 +26,7 @@
 
 namespace LibreNMS\Tests\Feature\SnmpTraps;
 
-class AdvaObjectCreationTest extends SnmpTrapTestCase
+final class AdvaObjectCreationTest extends SnmpTrapTestCase
 {
     public function testUserCreation(): void
     {

diff --git a/tests/Feature/SnmpTraps/AdvaObjectDeletionTest.php b/tests/Feature/SnmpTraps/AdvaObjectDeletionTest.php
@@ -26,7 +26,7 @@
 
 namespace LibreNMS\Tests\Feature\SnmpTraps;
 
-class AdvaObjectDeletionTest extends SnmpTrapTestCase
+final class AdvaObjectDeletionTest extends SnmpTrapTestCase
 {
     public function testUserDeletion(): void
     {

diff --git a/tests/Feature/SnmpTraps/AdvaStateChangeTrapTest.php b/tests/Feature/SnmpTraps/AdvaStateChangeTrapTest.php
@@ -26,7 +26,7 @@
 
 namespace LibreNMS\Tests\Feature\SnmpTraps;
 
-class AdvaStateChangeTrapTest extends SnmpTrapTestCase
+final class AdvaStateChangeTrapTest extends SnmpTrapTestCase
 {
     public function testAccessPortChg(): void
     {

diff --git a/tests/Feature/SnmpTraps/AdvaSysAlmTrapTest.php b/tests/Feature/SnmpTraps/AdvaSysAlmTrapTest.php
@@ -28,7 +28,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class AdvaSysAlmTrapTest extends SnmpTrapTestCase
+final class AdvaSysAlmTrapTest extends SnmpTrapTestCase
 {
     public function testCriticalAlarm(): void
     {

diff --git a/tests/Feature/SnmpTraps/ApcOnBatteryTest.php b/tests/Feature/SnmpTraps/ApcOnBatteryTest.php
@@ -27,7 +27,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class ApcOnBatteryTest extends SnmpTrapTestCase
+final class ApcOnBatteryTest extends SnmpTrapTestCase
 {
     /**
      * Test ApcOnBattery handle

diff --git a/tests/Feature/SnmpTraps/ApcPduOutletTest.php b/tests/Feature/SnmpTraps/ApcPduOutletTest.php
@@ -25,7 +25,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class ApcPduOutletTest extends SnmpTrapTestCase
+final class ApcPduOutletTest extends SnmpTrapTestCase
 {
     public function testOutletOff(): void
     {

diff --git a/tests/Feature/SnmpTraps/ApcPduOverloadTest.php b/tests/Feature/SnmpTraps/ApcPduOverloadTest.php
@@ -25,7 +25,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class ApcPduOverloadTest extends SnmpTrapTestCase
+final class ApcPduOverloadTest extends SnmpTrapTestCase
 {
     /**
      * Test ApcPduNearOverload trap handle

diff --git a/tests/Feature/SnmpTraps/ApcPowerRestoredTest.php b/tests/Feature/SnmpTraps/ApcPowerRestoredTest.php
@@ -27,7 +27,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class ApcPowerRestoredTest extends SnmpTrapTestCase
+final class ApcPowerRestoredTest extends SnmpTrapTestCase
 {
     /**
      * Test ApcPowerRestored handle

diff --git a/tests/Feature/SnmpTraps/ApcSmartAvrReducingOffTest.php b/tests/Feature/SnmpTraps/ApcSmartAvrReducingOffTest.php
@@ -27,7 +27,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class ApcSmartAvrReducingOffTest extends SnmpTrapTestCase
+final class ApcSmartAvrReducingOffTest extends SnmpTrapTestCase
 {
     /**
      * Test ApcSmartAvrReducingOff handle

diff --git a/tests/Feature/SnmpTraps/ApcSmartAvrReducingTest.php b/tests/Feature/SnmpTraps/ApcSmartAvrReducingTest.php
@@ -27,7 +27,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class ApcSmartAvrReducingTest extends SnmpTrapTestCase
+final class ApcSmartAvrReducingTest extends SnmpTrapTestCase
 {
     /**
      * Test ApcSmartAvrReducing handle

diff --git a/tests/Feature/SnmpTraps/AxisVideoTrapTest.php b/tests/Feature/SnmpTraps/AxisVideoTrapTest.php
@@ -26,7 +26,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class AxisVideoTrapTest extends SnmpTrapTestCase
+final class AxisVideoTrapTest extends SnmpTrapTestCase
 {
     /**
      * Test Axis Video trap handlers

diff --git a/tests/Feature/SnmpTraps/BgpTrapTest.php b/tests/Feature/SnmpTraps/BgpTrapTest.php
@@ -34,7 +34,7 @@
 use LibreNMS\Tests\Traits\RequiresDatabase;
 use LibreNMS\Util\AutonomousSystem;
 
-class BgpTrapTest extends SnmpTrapTestCase
+final class BgpTrapTest extends SnmpTrapTestCase
 {
     use RequiresDatabase;
     use DatabaseTransactions;

diff --git a/tests/Feature/SnmpTraps/CienaCesAAAUserAuthenticationEventTest.php b/tests/Feature/SnmpTraps/CienaCesAAAUserAuthenticationEventTest.php
@@ -28,7 +28,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class CienaCesAAAUserAuthenticationEventTest extends SnmpTrapTestCase
+final class CienaCesAAAUserAuthenticationEventTest extends SnmpTrapTestCase
 {
     public function testAuthSuccess(): void
     {

diff --git a/tests/Feature/SnmpTraps/CienaCesPortNotificationTrapTest.php b/tests/Feature/SnmpTraps/CienaCesPortNotificationTrapTest.php
@@ -34,12 +34,12 @@
 use LibreNMS\Enum\Severity;
 use LibreNMS\Tests\Traits\RequiresDatabase;
 
-class CienaCesPortNotificationTrapTest extends SnmpTrapTestCase
+final class CienaCesPortNotificationTrapTest extends SnmpTrapTestCase
 {
     use RequiresDatabase;
     use DatabaseTransactions;
 
-    public function testCienaCesPortDownNotification()
+    public function testCienaCesPortDownNotification(): void
     {
         // make a device and associate a port with it
         $device = Device::factory()->create(); /** @var Device $device */
@@ -69,7 +69,7 @@ public function testCienaCesPortDownNotification()
         $this->assertEquals($port->ifOperStatus, 'down');
     }
 
-    public function testCienaCesPortUpNotification()
+    public function testCienaCesPortUpNotification(): void
     {
         // make a device and associate a port with it
         $device = Device::factory()->create(); /** @var Device $device */

diff --git a/tests/Feature/SnmpTraps/CiscoDHCPServerTrapTest.php b/tests/Feature/SnmpTraps/CiscoDHCPServerTrapTest.php
@@ -26,7 +26,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class CiscoDHCPServerTrapTest extends SnmpTrapTestCase
+final class CiscoDHCPServerTrapTest extends SnmpTrapTestCase
 {
     /**
      * Test CiscoDHCPServer trap handles

diff --git a/tests/Feature/SnmpTraps/CiscoErrDisableInterfaceEventTest.php b/tests/Feature/SnmpTraps/CiscoErrDisableInterfaceEventTest.php
@@ -32,7 +32,7 @@
 use LibreNMS\Enum\Severity;
 use LibreNMS\Tests\Traits\RequiresDatabase;
 
-class CiscoErrDisableInterfaceEventTest extends SnmpTrapTestCase
+final class CiscoErrDisableInterfaceEventTest extends SnmpTrapTestCase
 {
     use RequiresDatabase;
     use DatabaseTransactions;

diff --git a/tests/Feature/SnmpTraps/CiscoLdpSesTest.php b/tests/Feature/SnmpTraps/CiscoLdpSesTest.php
@@ -34,7 +34,7 @@
 use LibreNMS\Enum\Severity;
 use LibreNMS\Tests\Traits\RequiresDatabase;
 
-class CiscoLdpSesTest extends SnmpTrapTestCase
+final class CiscoLdpSesTest extends SnmpTrapTestCase
 {
     use RequiresDatabase;
     use DatabaseTransactions;

diff --git a/tests/Feature/SnmpTraps/CiscoMacViolationTest.php b/tests/Feature/SnmpTraps/CiscoMacViolationTest.php
@@ -25,7 +25,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class CiscoMacViolationTest extends SnmpTrapTestCase
+final class CiscoMacViolationTest extends SnmpTrapTestCase
 {
     /**
      * Test CiscoMacViolation trap handle

diff --git a/tests/Feature/SnmpTraps/CiscoNSTrapTest.php b/tests/Feature/SnmpTraps/CiscoNSTrapTest.php
@@ -26,7 +26,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class CiscoNSTrapTest extends SnmpTrapTestCase
+final class CiscoNSTrapTest extends SnmpTrapTestCase
 {
     /**
      * Test Axis Video trap handlers

diff --git a/tests/Feature/SnmpTraps/CommonTrapTest.php b/tests/Feature/SnmpTraps/CommonTrapTest.php
@@ -37,7 +37,7 @@
 use LibreNMS\Tests\Traits\RequiresDatabase;
 use Log;
 
-class CommonTrapTest extends SnmpTrapTestCase
+final class CommonTrapTest extends SnmpTrapTestCase
 {
     use RequiresDatabase;
     use DatabaseTransactions;

diff --git a/tests/Feature/SnmpTraps/CppmServiceRestartTrapTest.php b/tests/Feature/SnmpTraps/CppmServiceRestartTrapTest.php
@@ -28,7 +28,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class CppmServiceRestartTrapTest extends SnmpTrapTestCase
+final class CppmServiceRestartTrapTest extends SnmpTrapTestCase
 {
     public function testServiceRestart(): void
     {

diff --git a/tests/Feature/SnmpTraps/CppmServiceStartTrapTest.php b/tests/Feature/SnmpTraps/CppmServiceStartTrapTest.php
@@ -28,7 +28,7 @@
 
 use LibreNMS\Enum\Severity;
 
-class CppmServiceStartTrapTest extends SnmpTrapTestCase
+final class CppmServiceStartTrapTest extends SnmpTrapTestCase
 {
     public function testServiceStart(): void
     {