Skip to content

Apply fixes from StyleCI #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
murrant merged 1 commit into from
Nov 25, 2025
Merged

Apply fixes from StyleCI #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/Models/Port.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ public function getDescription(): string

/**
* Get port speeds, respecting parsed interface circuit speeds as bps
*
* @return array{int, int} [egress bps, ingress bps]
*/
public function getSpeeds(): array
Expand Down
1 change: 0 additions & 1 deletion includes/html/graphs/generic_data.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@
$rrd_options .= ' LINE1:percentile_in#aa0000';
$rrd_options .= ' LINE1:dpercentile_out#aa0000';


$speed_line_type = ($vars['port_speed_zoom'] ?? LibrenmsConfig::get('graphs.port_speed_zoom')) ? 'LINE2' : 'HRULE';
if ($egress_speed && $ingress_speed && $ingress_speed != $egress_speed) {
$rrd_options .= " $speed_line_type:$ingress_speed#000000:'In Port Speed " . Number::formatSi($ingress_speed, 2, 0, 'bps') . "\\n'";
Expand Down
6 changes: 3 additions & 3 deletions includes/polling/ports.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,12 +748,12 @@
$port_parser ??= include LibrenmsConfig::get('install_dir') . '/' . LibrenmsConfig::get('port_descr_parser');

// handle functional style parsers
if(is_callable($port_parser)) {
if (is_callable($port_parser)) {
$port_ifAlias = app()->call($port_parser, [
'ifAlias' => $this_port['ifAlias'] ,
'ifAlias' => $this_port['ifAlias'],
'ifIndex' => $port['ifIndex'],
'ifName' => $this_port['ifName'],
'port_id' => $port['port_id']
'port_id' => $port['port_id'],
]);
} else {
unset($port_parser);
Expand Down
Loading