Fix ytdl-core VERSION

[whytf]

Summary

• Updates @distube/ytdl-core from v4.16.10 to v4.16.12
• Resolves YouTube player script parsing issues that were causing stream URL failures
• Fixes warnings about decipher function and n transform function parsing

Problem

The bot was experiencing errors when trying to play YouTube content:

WARNING: Could not parse decipher function.
Stream URLs will be missing.
WARNING: Could not parse n transform function.

This was happening because YouTube changed their player scripts, breaking the decipher function parsing in the older version of ytdl-core.

Solution

Updated @distube/ytdl-core to the latest version (4.16.12) which includes updated parsing logic to handle YouTube's recent changes.

Testing

✅ Docker build passes successfully
✅ Bot functionality restored for YouTube content

Dependencies

Updated @distube/ytdl-core from ^4.16.10 to ^4.16.12
No breaking changes or API modifications required

[codetheweb]

📦 🤖 A new release has been made for this pull request.

To play around with this PR, pull ghcr.io/museofficial/muse:pr-1280.

Images are available for x86_64 and ARM64.

Latest commit: cb3ae88

[DovahBrownies]

@whytf Is this any different than #1256 ?

[whytf]

@whytf Is this any different than #1256 ?

Look at files changed, I only changed the version for ytdl

[DovahBrownies]

@whytf Is this any different than #1256 ?

Look at files changed, I only changed the version for ytdl

Yes I am aware of that.
Rephrasing the question; Does this PR make any changes that #1256 doesn't already? If not, why the repetitive pull requests?

[whytf]

@whytf Is this any different than #1256 ?

Look at files changed, I only changed the version for ytdl

Yes I am aware of that. Rephrasing the question; Does this PR make any changes that #1256 doesn't already? If not, why the repetitive pull requests?

I don't trust those changes and since I needed to fix my deployment, i'll rather use my own PR image

Also there's unnecessary yarn.lock being pushed as well, incorrect changelog and unexplained change to src/services/player.ts

[DovahBrownies]

@whytf Is this any different than #1256 ?

Look at files changed, I only changed the version for ytdl

Yes I am aware of that. Rephrasing the question; Does this PR make any changes that #1256 doesn't already? If not, why the repetitive pull requests?

I don't trust those changes and since I needed to fix my deployment, i'll rather use my own PR image

Also there's unnecessary yarn.lock being pushed as well, incorrect changelog and unexplained change to src/services/player.ts

Changes are public and nothing changed is suspicious.
The change to player.ts seems to be purely a linting thing; It just moves an import down.
The changelog seems fine? I could be wrong here.
And the lock file being pushed is unnecessary? I wouldn't say so. This is a preferential thing and it looks like the maintainers here subscribe to the idea of having an updated remote lock file.

In any case, if you want a working docker image, feel free to use mine.

[whytf]

In any case, if you want a working docker image, feel free to use mine.

Thanks, but I stick to zero trust opsec

[DovahBrownies]

In any case, if you want a working docker image, feel free to use mine.

Thanks, but I stick to zero trust opsec

Then I would highly recommend against cloning or pulling open-source repositories.

[whytf]

In any case, if you want a working docker image, feel free to use mine.

Thanks, but I stick to zero trust opsec

Then I would highly recommend against cloning or pulling open-source repositories.

No worries, cloned muse and next changes will be mine, unlike artifacts from third party PRs