Skip to content

Conversation

@prodoelmit
Copy link
Contributor

Resolves: #27869

  • Stores TransposeOptions as static variable of TransposeDialog.
  • When applying transpose, saves used options to that static variable
  • Only applies to mode, direction and interval (there is more complex logic in initialization for other fields)
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@prodoelmit prodoelmit force-pushed the feature-27869-restore-transpose-settings branch from e64c6a7 to 39ef90e Compare September 20, 2025 21:02
@cbjeukendrup cbjeukendrup force-pushed the feature-27869-restore-transpose-settings branch from 39ef90e to c543a9b Compare October 23, 2025 13:31
@miiizen miiizen self-assigned this Nov 25, 2025
@miiizen miiizen self-requested a review November 25, 2025 15:51
@miiizen miiizen force-pushed the feature-27869-restore-transpose-settings branch 2 times, most recently from 692bf62 to cd602bc Compare December 1, 2025 12:44
@miiizen miiizen requested a review from avvvvve December 1, 2025 12:44
@avvvvve
Copy link

avvvvve commented Dec 1, 2025

I don't know if this is included in "other fields" as mentioned in the issue description (can you confirm @prodoelmit?), but it would be nice if the nested radio buttons maintained their state.

To reproduce:

  1. In the 'To key' section, change the key and select 'Down' as the direction, then run the transposition.
  2. Reopen the dialog and see that both the dropdown and radio button are recalled correctly.
  3. Change to 'By interval' and transpose again.
  4. Reopen the dialog. Now, in the 'To key' section, the last key chosen is still recalled, but the radio button has been reset to the first option ('Closest').

I'd expect the 'Down' radio button to still be selected.

Screen.Recording.2025-12-01.at.11.26.12.AM.mov

@miiizen miiizen force-pushed the feature-27869-restore-transpose-settings branch from cd602bc to bc6842a Compare December 19, 2025 14:49
* Stores TransposeOptions as static variable of TransposeDialog.
* When applying transpose, saves used options to that static variable
@miiizen miiizen force-pushed the feature-27869-restore-transpose-settings branch from bc6842a to a7b9ca3 Compare January 7, 2026 17:17
Copy link

@avvvvve avvvvve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@miiizen miiizen merged commit 1cc93ff into musescore:master Jan 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recall last Transpose settings when reopening the Transpose window

3 participants