Overhaul note input cursor rect logic #30953
Open
+65
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for tab input cursor
cbjeukendrup
force-pushed
the
10664_tab_note_input_cursor
branch
from
bb8dbef to
0ebbfd9
Compare
Contributor
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approvedhttps://github.com//issues/10664 FIXED |
bkunda
reviewed
Nov 11, 2025
bkunda
left a comment
bkunda
left a comment
There was a problem hiding this comment.
Very nice work! My only (incredibly pedantic) comment is that the padding within the blue box around specifically 2-digit fret numbers is perhaps a tad generous (by maybe only a couple of pixels). The padding around single-digit fret numbers is fine.
✅ All good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #10664
Use spatium instead of constant values, in order not to depend on DPI
Fix calculation of segment content rect on TAB staves (translate bbox of Chord children by their position within the chord)
Move that calculation out of the Segment class, as it's not relevant in any way for the engraving module
Merges #30729