Fix Fret Diagram Legend bugs after save-reopen #31900
Open
+28
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiizen
approved these changes
Jan 27, 2026
Contributor
Contributor
mike-spa
force-pushed
the
fixFretBoxBugs
branch
from
ef100f4 to
dcad1e7
Compare
Contributor
Author
|
@DmitryArefiev sorry I've been busy on other stuff. I've now fixed also the second issue, and I also noticed that the reset button on the panel wasn't reordering the list correctly. That should now be fixed too. |
Contributor
|
@mike-spa Looks like it doesn't update FDL right after changing chord position and Reset button doesn't work properly yet bandicam.2026-01-29.18-03-59-709.mp4 |
mike-spa
force-pushed
the
fixFretBoxBugs
branch
from
dcad1e7 to
0ca5352
Compare
Contributor
Author
|
@DmitryArefiev please try again, I hope it works this time 😅 |
Contributor
|
@mike-spa Nope.. it still occurs bandicam.2026-02-01.22-56-36-917.mp4 |
mike-spa
force-pushed
the
fixFretBoxBugs
branch
from
0ca5352 to
8aa9f39
Compare
mike-spa
force-pushed
the
fixFretBoxBugs
branch
from
8aa9f39 to
76c66e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30327
Resolves: #31947