Open
Conversation
shoogle
reviewed
Mar 27, 2026
|
|
||
| static const mu::engraving::Fraction DEFAULT_TICK = mu::engraving::Fraction(0, 1); | ||
|
|
||
| static String formatInstrumentTitleOnScore(const String& instrumentName, const Trait& trait) |
Contributor
There was a problem hiding this comment.
It's strange that this function isn't used anywhere. It's supposed to be used to construct the instrument names you see in the score (but not in the UI where a different function is used).
Contributor
Author
There was a problem hiding this comment.
Yes it seems unused. See also #32821, which also wants to remove it
8 tasks
reg.: declaration of 'staffIdx' hides previous local declaration (C4456)
reg.: 'formatInstrumentTitleOnScore': unreferenced function with internal linkage has been removed (C4505)
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
from
85ae53c to
67beed6
Compare
reg.: "SRC:/src/framework/ui/view/widgetdialog.cpp" is empty.
Jojo-Schmitz
force-pushed
the
compiler-warnings
branch
from
67beed6 to
01c405b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.