Open
Conversation
src/framework/global/thirdparty/kors_async/async/internal/channelimpl.h
Outdated
Show resolved
Hide resolved
Contributor
|
It's slightly annoying that |
miiizen
reviewed
Mar 30, 2026
| ldata->setShape(shape); | ||
|
|
||
| if (!item->text()) { | ||
| const_cast<Bracket*>(item)->setText(new Text(const_cast<Bracket*>(item), TextStyleType::GROUP_BRACKET)); |
Contributor
There was a problem hiding this comment.
Suggested change
| const_cast<Bracket*>(item)->setText(new Text(const_cast<Bracket*>(item), TextStyleType::GROUP_BRACKET)); | |
| Text* bracketText = new Text(const_cast<Bracket*>(item), TextStyleType::GROUP_BRACKET); | |
| bracketText->setGenerated(true); | |
| const_cast<Bracket*>(item)->setText(bracketText); |
You can then remove the Text::isEditable override.
| { | ||
| initElementStyle(&defaultStyle); | ||
|
|
||
| setSelectable(!parent->isBracket()); |
Contributor
There was a problem hiding this comment.
We can add the GROUP_BRACKET text style type to styleIsSelectable instead of this line. (Unless in future we want users to be able to change the text style of individual instances of bracket text)
| // (the second case happens at least when the bracket is initially dropped) | ||
| bool notHidden = ctx.conf().styleB(Sid::alwaysShowBracketsWhenEmptyStavesAreHidden) | ||
| ? (staffIdx1 <= staffIdx2) : (staffIdx1 < staffIdx2) || (b->span() == 1 && staffIdx1 == staffIdx2); | ||
| if (notHidden) { // set vert. pos. and height to visible spanned staves |
Contributor
There was a problem hiding this comment.
Would it be better to check the inverse of this and continue to skip layout completely? (Unless we need to lay out brackets with 0 height for horizontal spacing?)
| staffIdx += nstaves; | ||
| } | ||
|
|
||
| for (staff_idx_t staffIdx = 0; staffIdx < system->staves().size(); ++staffIdx) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.