Refactor EditStaff::apply() to use m_orgStaff for undo stack access#32828
Draft
CubikingChill wants to merge 1 commit intomusescore:masterfrom
Draft
Refactor EditStaff::apply() to use m_orgStaff for undo stack access#32828CubikingChill wants to merge 1 commit intomusescore:masterfrom
CubikingChill wants to merge 1 commit intomusescore:masterfrom
Conversation
Use m_orgStaff->score()->undoStack() instead of m_staff->score()->undoStack() for better code clarity and semantic correctness. While both references point to the same undo stack (since m_staff and m_orgStaff share the same Part), using m_orgStaff makes the intent clearer: we're accessing the undo stack of the score containing the staff being modified, not the temporary UI copy used for staging changes.
Contributor
|
@zacjansheski please test the "Staff/Part properties" dialog (there are no crashes or other problems when pressing Apply) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use m_orgStaff->score()->undoStack() instead of m_staff->score()->undoStack() for better code clarity and semantic correctness.
While both references point to the same undo stack (since m_staff and m_orgStaff share the same Part), using m_orgStaff makes the intent clearer: we're accessing the undo stack of the score containing the staff being modified, not the temporary UI copy used for staging changes.