Skip to content

[Draft] Main menu and title will follow font size in preferences#32831

Draft
krasko78 wants to merge 2 commits intomusescore:masterfrom
krasko78:MainMenuToUsePreferencesFontSize
Draft

[Draft] Main menu and title will follow font size in preferences#32831
krasko78 wants to merge 2 commits intomusescore:masterfrom
krasko78:MainMenuToUsePreferencesFontSize

Conversation

@krasko78
Copy link
Copy Markdown
Contributor

@krasko78 krasko78 commented Mar 28, 2026

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@krasko78 krasko78 marked this pull request as ready for review March 28, 2026 01:53
@krasko78 krasko78 marked this pull request as draft March 28, 2026 01:54
@krasko78
Copy link
Copy Markdown
Contributor Author

@avvvvve Here you go! :)

@avvvvve
Copy link
Copy Markdown

avvvvve commented Mar 30, 2026

@krasko78 thanks! I like it, but want to run it by @bkunda for approval too. he'll be back in next week.

@avvvvve
Copy link
Copy Markdown

avvvvve commented Mar 30, 2026

Actually, one quick thing that would improve this. When the text size gets to 17/18px with the default font, the menu items run into the score title and start pushing it over.

18px.mp4

Could we add some right padding to the menu item section so that there's a buffer between it and the title? Don't want it the title look like one of the menu items. Maybe try 24px.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bb7e88f5-3f59-42ab-806d-69a197c68199

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@krasko78
Copy link
Copy Markdown
Contributor Author

@avvvvve I've added 24px of min distance between the menu and the title. There's already 8px distance between them by default, so now it will be a total of 8 + 24 = 32px. We can reduce the added padding to 16 so the total is 24 if you want. Personally I wouldn't do that because the separation would become too small and the title would still look like a menu item. But that's just my opinion.

@avvvvve
Copy link
Copy Markdown

avvvvve commented Mar 30, 2026

Thanks! I had the existing 8px in mind ;)

I'll check again tomorrow, I can't get the build to open for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants