[Draft] Main menu and title will follow font size in preferences#32831
[Draft] Main menu and title will follow font size in preferences#32831krasko78 wants to merge 2 commits intomusescore:masterfrom
Conversation
|
@avvvvve Here you go! :) |
|
Actually, one quick thing that would improve this. When the text size gets to 17/18px with the default font, the menu items run into the score title and start pushing it over. 18px.mp4Could we add some right padding to the menu item section so that there's a buffer between it and the title? Don't want it the title look like one of the menu items. Maybe try 24px. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@avvvvve I've added 24px of min distance between the menu and the title. There's already 8px distance between them by default, so now it will be a total of 8 + 24 = 32px. We can reduce the added padding to 16 so the total is 24 if you want. Personally I wouldn't do that because the separation would become too small and the title would still look like a menu item. But that's just my opinion. |
|
Thanks! I had the existing 8px in mind ;) I'll check again tomorrow, I can't get the build to open for some reason. |
Uh oh!
There was an error while loading. Please reload this page.