Skip to content

Fix #31724: Double notehead when adding to Laissez Vibrer note#32832

Open
pombcoraft wants to merge 1 commit intomusescore:masterfrom
pombcoraft:lv-double-note-fix
Open

Fix #31724: Double notehead when adding to Laissez Vibrer note#32832
pombcoraft wants to merge 1 commit intomusescore:masterfrom
pombcoraft:lv-double-note-fix

Conversation

@pombcoraft
Copy link
Copy Markdown

Resolves: #31724

This fix changes the put_note action by excluding notes with a Laissez Vibrer tie, when the function checks whether a new note should be added as tied and when a new note is added to a chord by pitch. After this change, when a new note is added to another with a Laissez Vibrer, a single notehead is added, without any tie.

This commit also adds a unit test to confirm that a double notehead wasn't created.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

When adding a new note, to a note with a Laissez Vibrer,
a double notehead is wrongfully created.

This fix changes the put_note action by excluding notes with a
Laissez Vibrer tie, when the function checks whether a new note
should be added as tied and when a new note is added to a chord by
pitch. After this change, when a new note is added to
another with a Laissez Vibrer, a single notehead is added,
without any tie.

This commit also adds a unit test to confirm that a double notehead
wasn't created.
@miiizen miiizen self-requested a review March 30, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Laissez vibrer double notehead added when adding note

1 participant