Fix #31724: Double notehead when adding to Laissez Vibrer note#32832
Open
pombcoraft wants to merge 1 commit intomusescore:masterfrom
Open
Fix #31724: Double notehead when adding to Laissez Vibrer note#32832pombcoraft wants to merge 1 commit intomusescore:masterfrom
pombcoraft wants to merge 1 commit intomusescore:masterfrom
Conversation
When adding a new note, to a note with a Laissez Vibrer, a double notehead is wrongfully created. This fix changes the put_note action by excluding notes with a Laissez Vibrer tie, when the function checks whether a new note should be added as tied and when a new note is added to a chord by pitch. After this change, when a new note is added to another with a Laissez Vibrer, a single notehead is added, without any tie. This commit also adds a unit test to confirm that a double notehead wasn't created.
180902b to
9675820
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #31724
This fix changes the put_note action by excluding notes with a Laissez Vibrer tie, when the function checks whether a new note should be added as tied and when a new note is added to a chord by pitch. After this change, when a new note is added to another with a Laissez Vibrer, a single notehead is added, without any tie.
This commit also adds a unit test to confirm that a double notehead wasn't created.