Enable VSCode Intellisense on Unit Tests Files and Use NVM versions of Node.js in Husky Pre-commit#1479
Open
SimeonAT wants to merge 4 commits intomusic-assistant:mainfrom
Open
Enable VSCode Intellisense on Unit Tests Files and Use NVM versions of Node.js in Husky Pre-commit#1479SimeonAT wants to merge 4 commits intomusic-assistant:mainfrom
SimeonAT wants to merge 4 commits intomusic-assistant:mainfrom
Conversation
… and syntax highlighting to be enabled on all unit test files in the 'test' directory.
…sions of Node.js. If not, use version of Node.js defined in PATH.
…t using NVM, keep everything the same as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes two small modifications to the front-end unit testing setup:
The
includeintsconfig.jsonis changed so that VSCode Intellisense and syntax highlighting are enabled when viewing all unit test files intest/*.Husky pre-commit is modified to use NVM versions of Node.js and
npmif they are found. If NVM is used, the Node.js andnpmversions used by NVM is printed to the console:I have Yarn, along with all Music Assistant front-end dependencies, installed on my NVM versions of Node.js and
npm. As a result, I initially had some trouble running the Husky pre-commit script as myPATHversions of Node.js were outdated. I believe that this fix could be helpful for contributors who use NVM to manage their Node.js versions.