fix(mux-player): Make error dialog not accessible when hidden#1075
Closed
AdamJaggard wants to merge 1 commit intomuxinc:mainfrom
Closed
fix(mux-player): Make error dialog not accessible when hidden#1075AdamJaggard wants to merge 1 commit intomuxinc:mainfrom
AdamJaggard wants to merge 1 commit intomuxinc:mainfrom
Conversation
|
@AdamJaggard is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
should be fine but let me quickly add this in media-chrome, that opacity line was also intended to get into MC... |
luwes
added a commit
to muxinc/media-chrome
that referenced
this pull request
Feb 27, 2025
related muxinc/elements#1075 I tried using `@starting-style {}` but couldn't get that to work so let's do it old school.
Contributor
|
fixed in media-chrome v4.6.1 will go out in next release of mux-player |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A customer noticed in an audit that not hiding the error dialog via
visibilitycaused some accessibility issues as it was still reachable in some cases. I couldn't see an issue with proactively setting it tohiddenwhile we intend to hide it anyway, so have updated it.