Skip to content

feat: add optional mux logo to mux video#1090

Merged
luwes merged 8 commits intomuxinc:mainfrom
ronalduQualabs:feature/add-optional-mux-logo-to-mux-video
Apr 3, 2025
Merged

feat: add optional mux logo to mux video#1090
luwes merged 8 commits intomuxinc:mainfrom
ronalduQualabs:feature/add-optional-mux-logo-to-mux-video

Conversation

@ronalduQualabs
Copy link
Contributor

This resolves Issue #6 by implementing the following changes:
• Adds a watermark image element to the template.
• Introduces a new watermark-enabled attribute to the element.
• Reads the watermark-enabled attribute and displays the watermark image accordingly.

image

@vercel
Copy link

vercel bot commented Mar 27, 2025

@ronalduQualabs is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@ronalduQualabs ronalduQualabs marked this pull request as ready for review March 28, 2025 15:31
@ronalduQualabs ronalduQualabs requested a review from a team as a code owner March 28, 2025 15:31
@luwes
Copy link
Contributor

luwes commented Mar 28, 2025

this will probably have to be written a little differently. In CustomVideoElement there is a static getTemplateHTML method which creates the HTML that will go in the shadow DOM. It enables the media elements to SSR in React.

This method should be overridden and depending on the attributes it should render logo slot or not...

@ronalduQualabs ronalduQualabs requested a review from luwes March 31, 2025 19:32
@vercel
Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 7:40pm
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 7:40pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 7:40pm

@ronalduQualabs ronalduQualabs requested a review from luwes April 2, 2025 18:35
Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@luwes luwes changed the title Feature/add optional mux logo to mux video feat: add optional mux logo to mux video Apr 2, 2025
@luwes luwes merged commit e61c2fa into muxinc:main Apr 3, 2025
9 of 11 checks passed
@github-actions github-actions bot mentioned this pull request Apr 3, 2025
luwes pushed a commit that referenced this pull request Apr 3, 2025
🤖 I have created a release *beep* *boop*
---


<details><summary>@mux/mux-audio: 0.15.6</summary>

##
[0.15.6](https://github.com/muxinc/elements/compare/@mux/mux-audio@0.15.5...@mux/mux-audio@0.15.6)
(2025-04-03)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.28.5 to 0.28.6
</details>

<details><summary>@mux/mux-audio-react: 0.15.6</summary>

##
[0.15.6](https://github.com/muxinc/elements/compare/@mux/mux-audio-react@0.15.5...@mux/mux-audio-react@0.15.6)
(2025-04-03)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.28.5 to 0.28.6
</details>

<details><summary>@mux/playback-core: 0.28.6</summary>

##
[0.28.6](https://github.com/muxinc/elements/compare/@mux/playback-core@0.28.5...@mux/playback-core@0.28.6)
(2025-04-03)


### Bug Fixes

* allow extension less Mux m3u8 url as src
([#1096](#1096))
([5e85462](5e85462))
</details>

<details><summary>@mux/mux-player: 3.3.3</summary>

##
[3.3.3](https://github.com/muxinc/elements/compare/@mux/mux-player@3.3.2...@mux/mux-player@3.3.3)
(2025-04-03)


### Bug Fixes

* bump player.style from 0.1.6 to 0.1.7 in the prod-dependencies group
across 1 directory
([#1095](#1095))
([b9da4be](b9da4be))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-video bumped from 0.24.5 to 0.25.0
    * @mux/playback-core bumped from 0.28.5 to 0.28.6
</details>

<details><summary>@mux/mux-player-react: 3.3.3</summary>

##
[3.3.3](https://github.com/muxinc/elements/compare/@mux/mux-player-react@3.3.2...@mux/mux-player-react@3.3.3)
(2025-04-03)


### Miscellaneous Chores

* **@mux/mux-player-react:** Synchronize player versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/mux-player bumped from 3.3.2 to 3.3.3
    * @mux/playback-core bumped from 0.28.5 to 0.28.6
</details>

<details><summary>@mux/mux-video: 0.25.0</summary>

##
[0.25.0](https://github.com/muxinc/elements/compare/@mux/mux-video@0.24.5...@mux/mux-video@0.25.0)
(2025-04-03)


### Features

* add optional mux logo to mux video
([#1090](#1090))
([e61c2fa](e61c2fa))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.28.5 to 0.28.6
</details>

<details><summary>@mux/mux-video-react: 0.25.0</summary>

##
[0.25.0](https://github.com/muxinc/elements/compare/@mux/mux-video-react@0.24.5...@mux/mux-video-react@0.25.0)
(2025-04-03)


### Miscellaneous Chores

* **@mux/mux-video-react:** Synchronize video versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @mux/playback-core bumped from 0.28.5 to 0.28.6
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants