fix: respect hls.js fatal error flag if available#1099
Merged
luwes merged 2 commits intomuxinc:mainfrom Apr 9, 2025
Merged
Conversation
|
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cjpillsbury
reviewed
Apr 9, 2025
| const mediaErrorCode = MediaError.MEDIA_ERR_NETWORK; | ||
| const mediaError = new MediaError(message, mediaErrorCode, true, context); | ||
| // Being offline is not immediately a fatal error for playback. | ||
| const mediaError = new MediaError(message, mediaErrorCode, false, context); |
Contributor
There was a problem hiding this comment.
💪. There may be some (non hls.js) places where it does entail a fatal error... We can treat that as a followup.
cjpillsbury
reviewed
Apr 9, 2025
| } | ||
|
|
||
| const mediaError = new MediaError('', mediaErrorCode, true); | ||
| const mediaError = new MediaError('', mediaErrorCode, fatal ?? true); |
Contributor
There was a problem hiding this comment.
nice! treating fatal as an override of default 👌
cjpillsbury
approved these changes
Apr 9, 2025
Contributor
cjpillsbury
left a comment
cjpillsbury
left a comment
There was a problem hiding this comment.
one concern about the offline assumptions, but otherwise this lgtm. Also, even if the changes result in some things not being marked as fatal when they should be, you were right that the current code is arguably overly presumptuous in the other direction (at least given the possibilities of retries).
Merged
Merged
luwes
pushed a commit
that referenced
this pull request
Apr 10, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@mux/mux-audio: 0.15.7</summary> ## [0.15.7](https://github.com/muxinc/elements/compare/@mux/mux-audio@0.15.6...@mux/mux-audio@0.15.7) (2025-04-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.28.6 to 0.28.7 </details> <details><summary>@mux/mux-audio-react: 0.15.7</summary> ## [0.15.7](https://github.com/muxinc/elements/compare/@mux/mux-audio-react@0.15.6...@mux/mux-audio-react@0.15.7) (2025-04-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.28.6 to 0.28.7 </details> <details><summary>@mux/mux-player: 3.3.4</summary> ## [3.3.4](https://github.com/muxinc/elements/compare/@mux/mux-player@3.3.3...@mux/mux-player@3.3.4) (2025-04-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-video bumped from 0.25.0 to 0.25.1 * @mux/playback-core bumped from 0.28.6 to 0.28.7 </details> <details><summary>@mux/mux-player-react: 3.3.4</summary> ## [3.3.4](https://github.com/muxinc/elements/compare/@mux/mux-player-react@3.3.3...@mux/mux-player-react@3.3.4) (2025-04-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-player bumped from 3.3.3 to 3.3.4 * @mux/playback-core bumped from 0.28.6 to 0.28.7 </details> <details><summary>@mux/mux-video: 0.25.1</summary> ## [0.25.1](https://github.com/muxinc/elements/compare/@mux/mux-video@0.25.0...@mux/mux-video@0.25.1) (2025-04-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.28.6 to 0.28.7 </details> <details><summary>@mux/mux-video-react: 0.25.1</summary> ## [0.25.1](https://github.com/muxinc/elements/compare/@mux/mux-video-react@0.25.0...@mux/mux-video-react@0.25.1) (2025-04-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.28.6 to 0.28.7 </details> <details><summary>@mux/playback-core: 0.28.7</summary> ## [0.28.7](https://github.com/muxinc/elements/compare/@mux/playback-core@0.28.6...@mux/playback-core@0.28.7) (2025-04-10) ### Bug Fixes * respect hls.js fatal error flag if available ([#1099](#1099)) ([6350a9b](6350a9b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes an issue where playback is not broken yet but the player throws a fatal error making the error dialog show up while the video is playing underneath.