feat: retry logic for 412 not playable errors#1106
Merged
luwes merged 15 commits intomuxinc:mainfrom Jun 18, 2025
Merged
Conversation
|
@Pintorado is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
ronalduQualabs
approved these changes
Apr 30, 2025
luwes
reviewed
May 14, 2025
luwes
reviewed
Jun 3, 2025
luwes
reviewed
Jun 3, 2025
luwes
reviewed
Jun 3, 2025
packages/playback-core/src/index.ts
Outdated
Comment on lines
+1279
to
+1281
| } else { | ||
| hls.recoverMediaError(); | ||
| } |
Contributor
There was a problem hiding this comment.
I think this shouldn't be used here. recoverMediaError() is an attempt to recover a media decode error is my understanding or at least it's definitely not for a network error.
Contributor
Author
There was a problem hiding this comment.
You're right, I'll remove it
luwes
reviewed
Jun 3, 2025
luwes
reviewed
Jun 3, 2025
luwes
reviewed
Jun 3, 2025
luwes
reviewed
Jun 6, 2025
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
luwes
pushed a commit
that referenced
this pull request
Jun 23, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@mux/mux-audio: 0.15.10</summary> ## [0.15.10](https://github.com/muxinc/elements/compare/@mux/mux-audio@0.15.9...@mux/mux-audio@0.15.10) (2025-06-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/mux-audio-react: 0.15.10</summary> ## [0.15.10](https://github.com/muxinc/elements/compare/@mux/mux-audio-react@0.15.9...@mux/mux-audio-react@0.15.10) (2025-06-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/playback-core: 0.30.0</summary> ## [0.30.0](https://github.com/muxinc/elements/compare/@mux/playback-core@0.29.1...@mux/playback-core@0.30.0) (2025-06-23) ### Features * add free plan logo ([#1140](#1140)) ([a6b369e](a6b369e)) * Google IMA support for mux-player and mux-video variants ([#1128](#1128)) ([ec31d4d](ec31d4d)) * retry logic for 412 not playable errors ([#1106](#1106)) ([677c90a](677c90a)) ### Bug Fixes * **playback-core:** prefer uri value for chapters session metadata when available. ([#1145](#1145)) ([4dd2a50](4dd2a50)) * support URI and VALUE for session data ([#1146](#1146)) ([930ad72](930ad72)) </details> <details><summary>@mux/mux-player: 3.5.0</summary> ## [3.5.0](https://github.com/muxinc/elements/compare/@mux/mux-player@3.4.1...@mux/mux-player@3.5.0) (2025-06-23) ### Features * Google IMA support for mux-player and mux-video variants ([#1128](#1128)) ([ec31d4d](ec31d4d)) * retry logic for 412 not playable errors ([#1106](#1106)) ([677c90a](677c90a)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-video bumped from 0.25.3 to 0.26.0 * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/mux-player-react: 3.5.0</summary> ## [3.5.0](https://github.com/muxinc/elements/compare/@mux/mux-player-react@3.4.1...@mux/mux-player-react@3.5.0) (2025-06-23) ### Features * Google IMA support for mux-player and mux-video variants ([#1128](#1128)) ([ec31d4d](ec31d4d)) ### Bug Fixes * **mux-player-react news:** on demand ad tag url ([#1144](#1144)) ([fbf1bb0](fbf1bb0)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-player bumped from 3.4.1 to 3.5.0 * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/mux-video: 0.26.0</summary> ## [0.26.0](https://github.com/muxinc/elements/compare/@mux/mux-video@0.25.3...@mux/mux-video@0.26.0) (2025-06-23) ### Features * add free plan logo ([#1140](#1140)) ([a6b369e](a6b369e)) * Google IMA support for mux-player and mux-video variants ([#1128](#1128)) ([ec31d4d](ec31d4d)) ### Bug Fixes * typeerror getLogoHTML of undefined ([35478ce](35478ce)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/mux-video-react: 0.26.0</summary> ## [0.26.0](https://github.com/muxinc/elements/compare/@mux/mux-video-react@0.25.3...@mux/mux-video-react@0.26.0) (2025-06-23) ### Miscellaneous Chores * **@mux/mux-video-react:** Synchronize video versions ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
luwes
pushed a commit
that referenced
this pull request
Jun 23, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@mux/mux-audio: 0.15.10</summary> ## [0.15.10](https://github.com/muxinc/elements/compare/@mux/mux-audio@0.15.9...@mux/mux-audio@0.15.10) (2025-06-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/mux-audio-react: 0.15.10</summary> ## [0.15.10](https://github.com/muxinc/elements/compare/@mux/mux-audio-react@0.15.9...@mux/mux-audio-react@0.15.10) (2025-06-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/playback-core: 0.30.0</summary> ## [0.30.0](https://github.com/muxinc/elements/compare/@mux/playback-core@0.29.1...@mux/playback-core@0.30.0) (2025-06-23) ### Features * add free plan logo ([#1140](#1140)) ([a6b369e](a6b369e)) * Google IMA support for mux-player and mux-video variants ([#1128](#1128)) ([ec31d4d](ec31d4d)) * retry logic for 412 not playable errors ([#1106](#1106)) ([677c90a](677c90a)) ### Bug Fixes * **playback-core:** prefer uri value for chapters session metadata when available. ([#1145](#1145)) ([4dd2a50](4dd2a50)) * support URI and VALUE for session data ([#1146](#1146)) ([930ad72](930ad72)) </details> <details><summary>@mux/mux-player: 3.5.0</summary> ## [3.5.0](https://github.com/muxinc/elements/compare/@mux/mux-player@3.4.1...@mux/mux-player@3.5.0) (2025-06-23) ### Features * Google IMA support for mux-player and mux-video variants ([#1128](#1128)) ([ec31d4d](ec31d4d)) * retry logic for 412 not playable errors ([#1106](#1106)) ([677c90a](677c90a)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-video bumped from 0.25.3 to 0.26.0 * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/mux-player-react: 3.5.0</summary> ## [3.5.0](https://github.com/muxinc/elements/compare/@mux/mux-player-react@3.4.1...@mux/mux-player-react@3.5.0) (2025-06-23) ### Features * Google IMA support for mux-player and mux-video variants ([#1128](#1128)) ([ec31d4d](ec31d4d)) ### Bug Fixes * **mux-player-react news:** on demand ad tag url ([#1144](#1144)) ([fbf1bb0](fbf1bb0)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-player bumped from 3.4.1 to 3.5.0 * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/mux-video: 0.26.0</summary> ## [0.26.0](https://github.com/muxinc/elements/compare/@mux/mux-video@0.25.3...@mux/mux-video@0.26.0) (2025-06-23) ### Features * add free plan logo ([#1140](#1140)) ([a6b369e](a6b369e)) * Google IMA support for mux-player and mux-video variants ([#1128](#1128)) ([ec31d4d](ec31d4d)) ### Bug Fixes * typeerror getLogoHTML of undefined ([35478ce](35478ce)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/mux-video-react: 0.26.0</summary> ## [0.26.0](https://github.com/muxinc/elements/compare/@mux/mux-video-react@0.25.3...@mux/mux-video-react@0.26.0) (2025-06-23) ### Miscellaneous Chores * **@mux/mux-video-react:** Synchronize video versions ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
luwes
pushed a commit
that referenced
this pull request
Jun 24, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@mux/mux-audio: 0.15.10</summary> ## [0.15.10](https://github.com/muxinc/elements/compare/@mux/mux-audio@0.15.9...@mux/mux-audio@0.15.10) (2025-06-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/mux-audio-react: 0.15.10</summary> ## [0.15.10](https://github.com/muxinc/elements/compare/@mux/mux-audio-react@0.15.9...@mux/mux-audio-react@0.15.10) (2025-06-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/playback-core: 0.30.0</summary> ## [0.30.0](https://github.com/muxinc/elements/compare/@mux/playback-core@0.29.1...@mux/playback-core@0.30.0) (2025-06-23) ### Features * add free plan logo ([#1140](#1140)) ([a6b369e](a6b369e)) * Google IMA support for mux-player and mux-video variants ([#1128](#1128)) ([ec31d4d](ec31d4d)) * retry logic for 412 not playable errors ([#1106](#1106)) ([677c90a](677c90a)) ### Bug Fixes * **playback-core:** prefer uri value for chapters session metadata when available. ([#1145](#1145)) ([4dd2a50](4dd2a50)) * support URI and VALUE for session data ([#1146](#1146)) ([930ad72](930ad72)) </details> <details><summary>@mux/mux-player: 3.5.0</summary> ## [3.5.0](https://github.com/muxinc/elements/compare/@mux/mux-player@3.4.1...@mux/mux-player@3.5.0) (2025-06-23) ### Features * Google IMA support for mux-player and mux-video variants ([#1128](#1128)) ([ec31d4d](ec31d4d)) * retry logic for 412 not playable errors ([#1106](#1106)) ([677c90a](677c90a)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-video bumped from 0.25.3 to 0.26.0 * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/mux-player-react: 3.5.0</summary> ## [3.5.0](https://github.com/muxinc/elements/compare/@mux/mux-player-react@3.4.1...@mux/mux-player-react@3.5.0) (2025-06-23) ### Features * Google IMA support for mux-player and mux-video variants ([#1128](#1128)) ([ec31d4d](ec31d4d)) ### Bug Fixes * **mux-player-react news:** on demand ad tag url ([#1144](#1144)) ([fbf1bb0](fbf1bb0)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-player bumped from 3.4.1 to 3.5.0 * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/mux-video: 0.26.0</summary> ## [0.26.0](https://github.com/muxinc/elements/compare/@mux/mux-video@0.25.3...@mux/mux-video@0.26.0) (2025-06-23) ### Features * add free plan logo ([#1140](#1140)) ([a6b369e](a6b369e)) * Google IMA support for mux-player and mux-video variants ([#1128](#1128)) ([ec31d4d](ec31d4d)) ### Bug Fixes * typeerror getLogoHTML of undefined ([35478ce](35478ce)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> <details><summary>@mux/mux-video-react: 0.26.0</summary> ## [0.26.0](https://github.com/muxinc/elements/compare/@mux/mux-video-react@0.25.3...@mux/mux-video-react@0.26.0) (2025-06-23) ### Miscellaneous Chores * **@mux/mux-video-react:** Synchronize video versions ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.29.1 to 0.30.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #531
This PR refactors how the player handles 412 (NETWORK_NOT_READY) errors.
Changes
Behavior: