Conversation
this is needed for iOS. fix #643
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
cjpillsbury
approved these changes
Apr 28, 2025
Contributor
cjpillsbury
left a comment
cjpillsbury
left a comment
There was a problem hiding this comment.
Would like these to conform to the relevant APIs and yield promises that resolve on completion. Otherwise, LGTM. Defer to you on whether you want to create a new ticket for this as a fast follow or try to solve before merging.
Merged
luwes
pushed a commit
that referenced
this pull request
May 2, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@mux/mux-audio: 0.15.8</summary> ## [0.15.8](https://github.com/muxinc/elements/compare/@mux/mux-audio@0.15.7...@mux/mux-audio@0.15.8) (2025-05-01) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.28.7 to 0.29.0 </details> <details><summary>@mux/mux-audio-react: 0.15.8</summary> ## [0.15.8](https://github.com/muxinc/elements/compare/@mux/mux-audio-react@0.15.7...@mux/mux-audio-react@0.15.8) (2025-05-01) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.28.7 to 0.29.0 </details> <details><summary>@mux/playback-core: 0.29.0</summary> ## [0.29.0](https://github.com/muxinc/elements/compare/@mux/playback-core@0.28.7...@mux/playback-core@0.29.0) (2025-05-01) ### Features * add video-title attr & prop ([#1108](#1108)) ([7763a49](7763a49)), closes [#639](#639) </details> <details><summary>@mux/mux-player: 3.4.0</summary> ## [3.4.0](https://github.com/muxinc/elements/compare/@mux/mux-player@3.3.4...@mux/mux-player@3.4.0) (2025-05-01) ### Features * add fullscreen API on player element ([#1107](#1107)) ([205f3c8](205f3c8)) * add video-title attr & prop ([#1108](#1108)) ([7763a49](7763a49)), closes [#639](#639) ### Bug Fixes * bump player.style from 0.1.7 to 0.1.8 in the prod-dependencies group across 1 directory ([#1110](#1110)) ([34dcba4](34dcba4)) * bump the prod-dependencies group across 1 directory with 2 updates ([#1109](#1109)) ([7969b53](7969b53)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-video bumped from 0.25.1 to 0.25.2 * @mux/playback-core bumped from 0.28.7 to 0.29.0 </details> <details><summary>@mux/mux-player-react: 3.4.0</summary> ## [3.4.0](https://github.com/muxinc/elements/compare/@mux/mux-player-react@3.3.4...@mux/mux-player-react@3.4.0) (2025-05-01) ### Features * add video-title attr & prop ([#1108](#1108)) ([7763a49](7763a49)), closes [#639](#639) ### Bug Fixes * default-hidden-captions order bug for React ([#1105](#1105)) ([7b706ba](7b706ba)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-player bumped from 3.3.4 to 3.4.0 * @mux/playback-core bumped from 0.28.7 to 0.29.0 </details> <details><summary>@mux/mux-video: 0.25.2</summary> ## [0.25.2](https://github.com/muxinc/elements/compare/@mux/mux-video@0.25.1...@mux/mux-video@0.25.2) (2025-05-01) ### Bug Fixes * bump castable-video from 1.1.5 to 1.1.6 in the prod-dependencies group across 1 directory ([#1103](#1103)) ([9f27791](9f27791)) * bump the prod-dependencies group across 1 directory with 2 updates ([#1109](#1109)) ([7969b53](7969b53)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.28.7 to 0.29.0 </details> <details><summary>@mux/mux-video-react: 0.25.2</summary> ## [0.25.2](https://github.com/muxinc/elements/compare/@mux/mux-video-react@0.25.1...@mux/mux-video-react@0.25.2) (2025-05-01) ### Miscellaneous Chores * **@mux/mux-video-react:** Synchronize video versions ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.28.7 to 0.29.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 task
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is needed for iOS. fix #643