feat: add adblocker bypass option, expose player props, and conditional captions menu#1127
Merged
luwes merged 5 commits intomuxinc:main-news-playerfrom May 29, 2025
Conversation
|
@ronalduQualabs is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
cjpillsbury
reviewed
May 22, 2025
cjpillsbury
reviewed
May 22, 2025
…/improve-ad-blockers-behavior
luwes
pushed a commit
that referenced
this pull request
Jun 3, 2025
…al captions menu (#1127) This PR introduces the following improvements: • New `allowPlaybackWithAdBlocker` prop Allows the player to continue playback even when an adblocker is detected. • If false (default): shows a blocking popup when an adblocker is present. • If true: bypasses the restriction and allows normal playback. • Exposes underlying player props on MuxNewsPlayer Enables more granular configuration and control over the embedded player through MuxNewsPlayer. • Conditional captions menu Adds a captions menu that appears only when text tracks are available. • Allows users to disable captions if they prefer not to see them.
luwes
pushed a commit
that referenced
this pull request
Jun 12, 2025
…al captions menu (#1127) This PR introduces the following improvements: • New `allowPlaybackWithAdBlocker` prop Allows the player to continue playback even when an adblocker is detected. • If false (default): shows a blocking popup when an adblocker is present. • If true: bypasses the restriction and allows normal playback. • Exposes underlying player props on MuxNewsPlayer Enables more granular configuration and control over the embedded player through MuxNewsPlayer. • Conditional captions menu Adds a captions menu that appears only when text tracks are available. • Allows users to disable captions if they prefer not to see them.
luwes
pushed a commit
that referenced
this pull request
Jun 13, 2025
…al captions menu (#1127) This PR introduces the following improvements: • New `allowPlaybackWithAdBlocker` prop Allows the player to continue playback even when an adblocker is detected. • If false (default): shows a blocking popup when an adblocker is present. • If true: bypasses the restriction and allows normal playback. • Exposes underlying player props on MuxNewsPlayer Enables more granular configuration and control over the embedded player through MuxNewsPlayer. • Conditional captions menu Adds a captions menu that appears only when text tracks are available. • Allows users to disable captions if they prefer not to see them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following improvements:
• New
allowPlaybackWithAdBlockerpropAllows the player to continue playback even when an adblocker is detected.
• If false (default): shows a blocking popup when an adblocker is present.
• If true: bypasses the restriction and allows normal playback.
• Exposes underlying player props on MuxNewsPlayer
Enables more granular configuration and control over the embedded player through MuxNewsPlayer.
• Conditional captions menu
Adds a captions menu that appears only when text tracks are available.
• Allows users to disable captions if they prefer not to see them.