feat: Google IMA support for mux-player and mux-video variants#1128
feat: Google IMA support for mux-player and mux-video variants#1128
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
cjpillsbury
left a comment
There was a problem hiding this comment.
Found an issue smoke testing https://elements-demo-nextjs-git-ads-video-mixin-mux.vercel.app/MuxNewsPlayer (play first ad + video, let 2nd play, note that ad does not play)
cjpillsbury
left a comment
There was a problem hiding this comment.
Confirmed fix works and code changes make sense! One callout re: src vs. playback-id scenarios, but can treat as a fast follow if it's complicated. Pre-approving either way. 🚀
|
Claude finished @luwes's task —— View job Hi! I see you've tagged me on this merged PR about Google IMA support. How can I help you? Please let me know what you'd like me to:
Just let me know what you need! |
|
@claude could you give a summary of the changes in this PR? |
|
Claude finished @luwes's task —— View job Summary of PR #1128 ChangesThis PR adds Google IMA (Interactive Media Ads) support to both Todo List:
🎯 Core Features AddedAd Support Types:
New Import Paths:
🏗️ Architecture & ImplementationMixin-Based Design:
Key Technical Decisions:
📦 Package Structure ChangesNew Exports Added: // mux-video exports
"./ads": ads web component
"./ads/mixin": ads mixin for custom implementations
"./ads/react": React wrapper
// mux-player exports
"./ads": ads web component
"./ads/mixin": ads mixin for custom implementations
"./themes/news": news theme with playlist supportBuild System Updates:
🎮 New API SurfaceHTML Attributes:
JavaScript Properties:
Events (16 new ad events):
🛠️ Implementation HighlightsAd Playback Flow:
State Management:
Platform Considerations:
🎨 News Theme AdditionNew Component:
📋 Examples & DocumentationDemo Pages Added:
Documentation:
🔍 Testing & QualityDependencies Added:
Error Handling:
Summary: This is a major feature addition that successfully isolates ads functionality while maintaining backward compatibility. The mixin-based architecture allows for clean separation of concerns, and the comprehensive event system provides full observability into the ad playback lifecycle. Scale: 51 commits, 56 files changed, 6,225 additions, 3,088 deletions - representing a significant enhancement to the Mux Elements ecosystem. |

fix #1120
This change adds support for the Google IMA client-side to the production variants of mux-video and mux-player.
Support is currently limited to linear pre, mid, and post roll ads. All ads logic is isolated from the standard mux-video and mux-player variants and requires a separate import path to include ad support.
Examples
Readme
New import paths
mux-player variants
web component
React
mux-video variants
web component
React