fix: Properly setup DRM to support Airplay by spuppo-mux · Pull Request #1245 · muxinc/elements

spuppo-mux · 2025-11-25T20:52:02Z

Closes #183

I also reorganized the onFpEncrypted callback to get a better understanding of the code and compare it with the FairPlay Streaming Overview.

The main issue here was that we were ignoring the Apple TV SPC when generating the DRM license. This is reflected on the session.addEventListener('message', ...) changes. We were listening just once to this message, but more recent versions of Apple TV send new messages when using AirPlay. Therefore I modified that listener to ask for that license again and update the session for each new message.

Note for reviewers: Please pay extra attention to the way I reformatted this code (not sure if I should change some Promise.reject), the new error messages and/or if I should be removing the event listener at some point.

vercel · 2025-11-25T20:52:08Z

@spuppo-mux is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

snyk-io · 2025-11-25T20:52:15Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

vercel · 2025-12-01T14:10:57Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
elements-demo-astro	Ready	Preview	Comment	Dec 3, 2025 9:11pm
elements-demo-nextjs	Ready	Preview	Comment	Dec 3, 2025 9:11pm
elements-demo-svelte-kit	Ready	Preview	Comment	Dec 3, 2025 9:11pm
elements-demo-vanilla	Ready	Preview	Comment	Dec 3, 2025 9:11pm
elements-demo-vue	Ready	Preview	Comment	Dec 3, 2025 9:11pm

packages/playback-core/src/index.ts

Copilot

Pull request overview

This PR fixes DRM support for AirPlay by properly handling multiple license requests from Apple TV. The main issue was that the code only listened once to the 'message' event, but newer Apple TV versions send multiple messages when using AirPlay.

Key Changes:

Refactored the FairPlay encryption handler into smaller, more maintainable functions
Changed the 'message' event listener from { once: true } to persistent to handle multiple AirPlay license requests
Updated error handling to use saveAndDispatchError consistently instead of Promise.reject

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/playback-core/src/index.ts

…changed saveAndDispatchError to Promise.reject to propagate failure; added teardown function to remove listeners and close session.

…handler

packages/playback-core/src/index.ts

luwes · 2025-12-03T19:32:17Z

packages/playback-core/src/index.ts

+          return;
+        }
+
+        console.error(errOrResp);


luwes

LGTM 👍

🤖 I have created a release *beep* *boop* --- <details><summary>@mux/mux-audio: 0.15.17</summary> ## [0.15.17](https://github.com/muxinc/elements/compare/@mux/mux-audio@0.15.16...@mux/mux-audio@0.15.17) (2025-12-04) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.31.4 to 0.32.0 </details> <details><summary>@mux/mux-audio-react: 0.15.17</summary> ## [0.15.17](https://github.com/muxinc/elements/compare/@mux/mux-audio-react@0.15.16...@mux/mux-audio-react@0.15.17) (2025-12-04) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.31.4 to 0.32.0 </details> <details><summary>@mux/playback-core: 0.32.0</summary> ## [0.32.0](https://github.com/muxinc/elements/compare/@mux/playback-core@0.31.4...@mux/playback-core@0.32.0) (2025-12-04) ### Features * add `max-auto-resolution` attribute for automatic resolution capping ([#1243](#1243)) ([a43edd5](a43edd5)) ### Bug Fixes * Properly setup DRM to support Airplay ([#1245](#1245)) ([673b7ff](673b7ff)) </details> <details><summary>@mux/mux-player: 3.10.0</summary> ## [3.10.0](https://github.com/muxinc/elements/compare/@mux/mux-player@3.9.2...@mux/mux-player@3.10.0) (2025-12-04) ### Features * add `max-auto-resolution` attribute for automatic resolution capping ([#1243](#1243)) ([a43edd5](a43edd5)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-video bumped from 0.28.2 to 0.29.0 * @mux/playback-core bumped from 0.31.4 to 0.32.0 </details> <details><summary>@mux/mux-player-astro: 3.10.0</summary> ## [3.10.0](https://github.com/muxinc/elements/compare/@mux/mux-player-astro@3.9.2...@mux/mux-player-astro@3.10.0) (2025-12-04) ### Miscellaneous Chores * **@mux/mux-player-astro:** Synchronize player versions ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-player bumped from 3.9.2 to 3.10.0 * @mux/playback-core bumped from 0.31.4 to 0.32.0 </details> <details><summary>@mux/mux-player-react: 3.10.0</summary> ## [3.10.0](https://github.com/muxinc/elements/compare/@mux/mux-player-react@3.9.2...@mux/mux-player-react@3.10.0) (2025-12-04) ### Features * add `max-auto-resolution` attribute for automatic resolution capping ([#1243](#1243)) ([a43edd5](a43edd5)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-player bumped from 3.9.2 to 3.10.0 * @mux/playback-core bumped from 0.31.4 to 0.32.0 </details> <details><summary>@mux/mux-video: 0.29.0</summary> ## [0.29.0](https://github.com/muxinc/elements/compare/@mux/mux-video@0.28.2...@mux/mux-video@0.29.0) (2025-12-04) ### Features * add `max-auto-resolution` attribute for automatic resolution capping ([#1243](#1243)) ([a43edd5](a43edd5)) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.31.4 to 0.32.0 </details> <details><summary>@mux/mux-video-react: 0.29.0</summary> ## [0.29.0](https://github.com/muxinc/elements/compare/@mux/mux-video-react@0.28.2...@mux/mux-video-react@0.29.0) (2025-12-04) ### Miscellaneous Chores * **@mux/mux-video-react:** Synchronize video versions ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.31.4 to 0.32.0 </details> <details><summary>@mux/mux-uploader: 1.4.1</summary> ## [1.4.1](https://github.com/muxinc/elements/compare/@mux/mux-uploader@1.4.0...@mux/mux-uploader@1.4.1) (2025-12-04) ### Bug Fixes * button text for file-select slot can now be customized ([#1252](#1252)) ([240d2ae](240d2ae)) </details> <details><summary>@mux/mux-uploader-astro: 1.4.1</summary> ## [1.4.1](https://github.com/muxinc/elements/compare/@mux/mux-uploader-astro@1.4.0...@mux/mux-uploader-astro@1.4.1) (2025-12-04) ### Miscellaneous Chores * **@mux/mux-uploader-astro:** Synchronize uploader versions ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-uploader bumped from 1.4.0 to 1.4.1 </details> <details><summary>@mux/mux-uploader-react: 1.4.1</summary> ## [1.4.1](https://github.com/muxinc/elements/compare/@mux/mux-uploader-react@1.4.0...@mux/mux-uploader-react@1.4.1) (2025-12-04) ### Miscellaneous Chores * **@mux/mux-uploader-react:** Synchronize uploader versions ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-uploader bumped from 1.4.0 to 1.4.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Reorganized Fairplay setup

199dad9

spuppo-mux requested a review from a team as a code owner November 25, 2025 20:52

spuppo-mux requested a review from cjpillsbury November 25, 2025 20:53

Fixes for lint Github Action

c9b506c

vercel bot deployed to Preview – elements-demo-vanilla December 1, 2025 14:12 View deployment

vercel bot deployed to Preview – elements-demo-vue December 1, 2025 14:12 View deployment

vercel bot deployed to Preview – elements-demo-svelte-kit December 1, 2025 14:13 View deployment

vercel bot deployed to Preview – elements-demo-nextjs December 1, 2025 14:14 View deployment

vercel bot deployed to Preview – elements-demo-astro December 1, 2025 14:14 View deployment

Merge branch 'main' into fix/drm_issues_over_airplay

c530d88

spuppo-mux commented Dec 2, 2025

View reviewed changes

packages/playback-core/src/index.ts Outdated Show resolved Hide resolved

luwes requested a review from Copilot December 2, 2025 19:01

Copilot AI reviewed Dec 2, 2025

View reviewed changes

packages/playback-core/src/index.ts Outdated Show resolved Hide resolved

packages/playback-core/src/index.ts Outdated Show resolved Hide resolved

packages/playback-core/src/index.ts Outdated Show resolved Hide resolved

spuppo-mux added 2 commits December 3, 2025 11:53

Moved generateRequest to the end of the function and added an await; …

79c2f9a

…changed saveAndDispatchError to Promise.reject to propagate failure; added teardown function to remove listeners and close session.

Added extra saveAndDispatchError for license key fail inside message …

f1a2858

…handler

spuppo-mux requested a review from luwes December 3, 2025 15:19

Save and dispatch error for other cases

8103017

luwes reviewed Dec 3, 2025

View reviewed changes

packages/playback-core/src/index.ts Outdated Show resolved Hide resolved

Restructured onMessage

5bc9a99

luwes reviewed Dec 3, 2025

View reviewed changes

packages/playback-core/src/index.ts

return;

}

console.error(errOrResp);

Copy link

Contributor

luwes Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

luwes approved these changes Dec 3, 2025

View reviewed changes

vercel bot deployed to Preview – elements-demo-vue December 3, 2025 19:47 View deployment

vercel bot deployed to Preview – elements-demo-nextjs December 3, 2025 19:47 View deployment

vercel bot deployed to Preview – elements-demo-vanilla December 3, 2025 19:48 View deployment

vercel bot deployed to Preview – elements-demo-svelte-kit December 3, 2025 19:48 View deployment

vercel bot deployed to Preview – elements-demo-astro December 3, 2025 19:49 View deployment

Merge branch 'main' into fix/drm_issues_over_airplay

3c21108

vercel bot deployed to Preview – elements-demo-vanilla December 3, 2025 21:09 View deployment

vercel bot deployed to Preview – elements-demo-vue December 3, 2025 21:10 View deployment

vercel bot deployed to Preview – elements-demo-svelte-kit December 3, 2025 21:10 View deployment

vercel bot deployed to Preview – elements-demo-nextjs December 3, 2025 21:11 View deployment

vercel bot deployed to Preview – elements-demo-astro December 3, 2025 21:11 View deployment

spuppo-mux merged commit 673b7ff into muxinc:main Dec 3, 2025
11 checks passed

github-actions bot mentioned this pull request Dec 3, 2025

chore: release main #1250

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Properly setup DRM to support Airplay#1245

fix: Properly setup DRM to support Airplay#1245
spuppo-mux merged 8 commits intomuxinc:mainfrom
spuppo-mux:fix/drm_issues_over_airplay

spuppo-mux commented Nov 25, 2025 •

edited

Loading

Uh oh!

vercel bot commented Nov 25, 2025

Uh oh!

snyk-io bot commented Nov 25, 2025 •

edited

Loading

Uh oh!

vercel bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luwes Dec 3, 2025

Uh oh!

luwes left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

spuppo-mux commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Nov 25, 2025

Uh oh!

snyk-io bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

vercel bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luwes Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

luwes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

spuppo-mux commented Nov 25, 2025 •

edited

Loading

snyk-io bot commented Nov 25, 2025 •

edited

Loading

vercel bot commented Dec 1, 2025 •

edited

Loading